elbv2 module_util - support alb attributes and add compare method for check_mode #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
|
recheck |
mandar242
approved these changes
Mar 4, 2022
jillr
reviewed
Mar 8, 2022
There was a problem hiding this comment.
Can you please update the unit tests for this module util? https://github.com/ansible-collections/amazon.aws/blob/main/tests/unit/module_utils/test_elbv2.py
jatorcasso
force-pushed
the
module_util/alb_attributes
branch
from
ad57cf7
to
6dfad9c
Compare
jatorcasso
changed the title
jatorcasso
force-pushed
the
module_util/alb_attributes
branch
from
0697b11
to
ccd5266
Compare
|
updated PR to include adding a compare_elb_attributes() to support check_mode when modifying ALB attributes |
jillr
approved these changes
Mar 9, 2022
|
regate |
alinabuzachis
added
mergeit
|
regate |
|
regate |
|
regate |
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #708 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 12, 2022
… check_mode (#696) elbv2 module_util - support alb attributes and add compare method for check_mode SUMMARY Add support for modifying alb specific attributes for ansible-collections/community.aws#963 Add compare_elb_attributes method to support check_mode ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.elb_application_lb amazon/aws/plugins/module_utils/elbv2.py Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Jill R <None> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit b14e392)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 18, 2022
… check_mode (#696) (#708) [PR #696/b14e392a backport][stable-3] elbv2 module_util - support alb attributes and add compare method for check_mode This is a backport of PR #696 as merged into main (b14e392). SUMMARY Add support for modifying alb specific attributes for ansible-collections/community.aws#963 Add compare_elb_attributes method to support check_mode ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.elb_application_lb amazon/aws/plugins/module_utils/elbv2.py
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Mar 26, 2022
elb_application_lb - support alb attributes SUMMARY Support modifying different alb specific attributes Fixes #571 Depends-On ansible-collections/amazon.aws#696 ISSUE TYPE Feature Pull Request COMPONENT NAME elb_application_lb Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None>
jatorcasso
added a commit
to jatorcasso/community.aws
that referenced
this pull request
Mar 28, 2022
elb_application_lb - support alb attributes SUMMARY Support modifying different alb specific attributes Fixes ansible-collections#571 Depends-On ansible-collections/amazon.aws#696 ISSUE TYPE Feature Pull Request COMPONENT NAME elb_application_lb Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 85bfce4)
1 task
1 task
goneri
pushed a commit
that referenced
this pull request
Sep 20, 2022
elb_application_lb - support alb attributes SUMMARY Support modifying different alb specific attributes Fixes #571 Depends-On #696 ISSUE TYPE Feature Pull Request COMPONENT NAME elb_application_lb Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@85bfce4
GomathiselviS
pushed a commit
to GomathiselviS/amazon.aws
that referenced
this pull request
Sep 20, 2022
elb_application_lb - support alb attributes SUMMARY Support modifying different alb specific attributes Fixes ansible-collections#571 Depends-On ansible-collections#696 ISSUE TYPE Feature Pull Request COMPONENT NAME elb_application_lb Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@85bfce4
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
elb_application_lb - support alb attributes SUMMARY Support modifying different alb specific attributes Fixes ansible-collections#571 Depends-On ansible-collections#696 ISSUE TYPE Feature Pull Request COMPONENT NAME elb_application_lb Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
elb_application_lb - support alb attributes SUMMARY Support modifying different alb specific attributes Fixes ansible-collections#571 Depends-On ansible-collections#696 ISSUE TYPE Feature Pull Request COMPONENT NAME elb_application_lb Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME