Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute instead of relative imports #809

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

nerijus
Copy link
Contributor

@nerijus nerijus commented May 11, 2022

This fixes mitogen-hq/mitogen#896. Although ansible without mitogen works without this PR, please consider accepting this PR, because some other files already have absolute imports, for example, ec2_instance.py, ec2_vpc_endpoint.py, etc.

@ansibullbot ansibullbot added community_review module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels May 11, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 53s
✔️ build-ansible-collection SUCCESS in 5m 30s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 59s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 9m 53s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 10m 44s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 40s
✔️ ansible-test-splitter SUCCESS in 2m 50s
✔️ integration-amazon.aws-1 SUCCESS in 17m 07s
✔️ integration-amazon.aws-2 SUCCESS in 24m 51s
✔️ integration-amazon.aws-3 SUCCESS in 36m 52s
✔️ integration-amazon.aws-4 SUCCESS in 18m 35s
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 7m 39s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
ansible-ee-tests-stable-2.12 FAILURE in 12m 39s (non-voting)

Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally good with this change. However, we should probably update the guidelines if we're going to do this. (docs/docsite/rst/dev_guidelines.rst) @nerijus If you're willing to add something that would be good, otherwise we can follow up afterwards as a house-keeping item.

@jillr @alinabuzachis - Any comments from the Cloud Content team side of things?
@markuman @marknet15 - As active community members any thoughts?

Do we want to put this on hold until the next meeting?

@marknet15
Copy link
Contributor

I generally prefer absolute imports anyway so this looks all good to me 👍

@nerijus
Copy link
Contributor Author

nerijus commented May 16, 2022

I'm generally good with this change. However, we should probably update the guidelines if we're going to do this. (docs/docsite/rst/dev_guidelines.rst) @nerijus If you're willing to add something that would be good, otherwise we can follow up afterwards as a house-keeping item.

I will better leave updating guidelines to somebody else :)

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 17, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 29s
✔️ build-ansible-collection SUCCESS in 4m 58s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 12s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 14m 50s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 9m 50s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 16s
✔️ ansible-test-splitter SUCCESS in 3m 04s
✔️ integration-amazon.aws-1 SUCCESS in 18m 01s
✔️ integration-amazon.aws-2 SUCCESS in 18m 03s
✔️ integration-amazon.aws-3 SUCCESS in 50m 40s
✔️ integration-amazon.aws-4 SUCCESS in 20m 21s
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 14m 40s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
ansible-ee-tests-stable-2.12 RETRY_LIMIT in 9m 35s (non-voting)

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 11ca163 into ansible-collections:main May 17, 2022
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
)

[3.0.0] Bump minimal botocore version to 1.19.0

SUMMARY
In preparation for release 3.0.0, bump the minimal botocore version
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
README.md
plugins/modules/aws_s3_bucket_info.py
requirements.txt
tests/integration/constraints.txt
tests/integration/targets/setup_botocore_pip/defaults/main.yml
tests/unit/constraints.txt
ADDITIONAL INFORMATION
Depends-On: ansible-collections#574

Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
)

[3.0.0] Bump minimal botocore version to 1.19.0

SUMMARY
In preparation for release 3.0.0, bump the minimal botocore version
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
README.md
plugins/modules/aws_s3_bucket_info.py
requirements.txt
tests/integration/constraints.txt
tests/integration/targets/setup_botocore_pip/defaults/main.yml
tests/unit/constraints.txt
ADDITIONAL INFORMATION
Depends-On: ansible-collections#574

Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
)

[3.0.0] Bump minimal botocore version to 1.19.0

SUMMARY
In preparation for release 3.0.0, bump the minimal botocore version
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
README.md
plugins/modules/aws_s3_bucket_info.py
requirements.txt
tests/integration/constraints.txt
tests/integration/targets/setup_botocore_pip/defaults/main.yml
tests/unit/constraints.txt
ADDITIONAL INFORMATION
Depends-On: ansible-collections#574

Reviewed-by: None <None>
wilfriedroset added a commit to wilfriedroset/awx that referenced this pull request Apr 29, 2024
Although Ansible without mitogen works without this PR it is not
possible to use it with Mitogen.

This is similar to ansible-collections/amazon.aws#809

Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some amazon.aws modules fail on relative import error
6 participants