Make profile mutually exclusive with other access tokens #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
tremble
added
the
do_not_backport
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
deprecation/4.0.0/profile
branch
from
81aa345
to
2a6b645
Compare
alinabuzachis
approved these changes
May 25, 2022
tremble
added
mergeit
tremble
force-pushed
the
deprecation/4.0.0/profile
branch
from
2a6b645
to
3fbe6fd
Compare
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
May 26, 2022
…ss tokens (#1155) Add changelog for profile becoming mutually exclusive with other access tokens Depends-On: ansible-collections/amazon.aws#834 SUMMARY amazon.aws/834 made profile mutually exclusive with the other access token parameters, add a changelog fragment to community.aws since it's a significant change that also affects this collection ISSUE TYPE Feature Pull Request COMPONENT NAME changelogs/fragments/151-profile-mutually-exclusive.yml ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de>
1 task
1 task
1 task
1 task
tremble
added a commit
that referenced
this pull request
Feb 22, 2023
fixes #1353 SUMMARY #1224 exposed that the removal of support for passing both profiles and security tokens was only partially implemented in release 5.0.0 (#834) Since we had already announced that support would be dropped for passing both (back in 2020 with release 1.2.0), I think it's reasonable to still fully drop support in 6.0.0. The documentation was originally very fuzzy about when we'd fallback and use which variables. ISSUE TYPE - Bugfix Pull Request COMPONENT NAME plugins/module_utils/botocore.py plugins/module_utils/modules.py ADDITIONAL INFORMATION
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
See also #130
Makes the profile parameter mutually exclusive with the aws_access_key, aws_secret_key and security_token parameters.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/botocore.py
ADDITIONAL INFORMATION
See also: #151 and #130