Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_vpc_igw - convert tags by default #835

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 24, 2022

SUMMARY

Updates ec2_vpc_igw so that it return tags as a dictionary by default (instead of the boto3 style list of dictionaries)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_vpc_igw

ADDITIONAL INFORMATION

See also ansible-collections/community.aws#318

@tremble tremble force-pushed the deprecation/4.0.0/ec2_vpc_igw branch from 97b9668 to 8afc3c0 Compare May 24, 2022 12:10
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request labels May 24, 2022
@tremble tremble added do_not_backport This PR should not be backported to stable- branches unless absolutely necessary and removed feature This issue/PR relates to a feature request community_review labels May 24, 2022
@ansibullbot ansibullbot added integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels May 24, 2022
@github-actions
Copy link

github-actions bot commented May 24, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 50s
✔️ build-ansible-collection SUCCESS in 5m 03s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 13s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 10m 21s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 9m 09s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 20s
✔️ ansible-test-splitter SUCCESS in 2m 29s
✔️ integration-amazon.aws-1 SUCCESS in 7m 15s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 50m 45s
✔️ integration-community.aws-2 SUCCESS in 12m 28s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble force-pushed the deprecation/4.0.0/ec2_vpc_igw branch from 8afc3c0 to 61ce7ab Compare May 24, 2022 13:55
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 5m 08s
✔️ build-ansible-collection SUCCESS in 5m 13s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 43s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 13m 54s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 13m 06s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 9m 01s
✔️ ansible-test-splitter SUCCESS in 2m 40s
✔️ integration-amazon.aws-1 SUCCESS in 9m 08s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 49m 10s
✔️ integration-community.aws-2 SUCCESS in 49m 05s
✔️ integration-community.aws-3 SUCCESS in 31m 26s
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 24, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 5m 11s
✔️ build-ansible-collection SUCCESS in 5m 31s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 34s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 10m 32s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 9m 37s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 16s
✔️ ansible-test-splitter SUCCESS in 2m 30s
✔️ integration-amazon.aws-1 SUCCESS in 8m 03s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants