[WIP] elb_classic_lb: fix return value _format_listener method to include SSLCertificateId #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
tremble
approved these changes
Jun 3, 2022
|
The change itself looks correct, I guess this is WIP because there's not integration tests? |
|
Oops, I expected removing mergeit to cancel the gate. Apparently it didn't... |
Yes, I am still trying to figure out a way for adding integration tests to this change, as for creating a lb with |
1 task
GomathiselviS
pushed a commit
to GomathiselviS/amazon.aws
that referenced
this pull request
Sep 21, 2022
add missing password_reset_required parameter SUMMARY password_reset_required parameter is missing in iam_user module. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_user ADDITIONAL INFORMATION Sadly, LoginProfile is only returned on create_login_profile and not on update_login_profile. Therefor the functionality can only be verified when the user is created, not when the user is udpated. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.create_login_profile https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.update_login_profile retval of update_login_profile is just 0.0s create_or_update_user: {'ResponseMetadata': {'HTTPHeaders': {'content-length': '216', 'content-type': 'text/xml', 'date': 'Wed, 12 Jan 2022 20:18:08 GMT', 'x-amzn-requestid': '11b6fde3-9f28-4265-8fac-88e3f5a238d3'}, 'HTTPStatusCode': 200, 'RequestId': '11b6fde3-9f28-4265-8fac-88e3f5a238d3', 'RetryAttempts': 0}} Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c0b3e1b
GomathiselviS
pushed a commit
to GomathiselviS/amazon.aws
that referenced
this pull request
Sep 21, 2022
add missing password_reset_required parameter SUMMARY password_reset_required parameter is missing in iam_user module. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_user ADDITIONAL INFORMATION Sadly, LoginProfile is only returned on create_login_profile and not on update_login_profile. Therefor the functionality can only be verified when the user is created, not when the user is udpated. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.create_login_profile https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.update_login_profile retval of update_login_profile is just 0.0s create_or_update_user: {'ResponseMetadata': {'HTTPHeaders': {'content-length': '216', 'content-type': 'text/xml', 'date': 'Wed, 12 Jan 2022 20:18:08 GMT', 'x-amzn-requestid': '11b6fde3-9f28-4265-8fac-88e3f5a238d3'}, 'HTTPStatusCode': 200, 'RequestId': '11b6fde3-9f28-4265-8fac-88e3f5a238d3', 'RetryAttempts': 0}} Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c0b3e1b
GomathiselviS
pushed a commit
to GomathiselviS/amazon.aws
that referenced
this pull request
Sep 22, 2022
add missing password_reset_required parameter SUMMARY password_reset_required parameter is missing in iam_user module. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_user ADDITIONAL INFORMATION Sadly, LoginProfile is only returned on create_login_profile and not on update_login_profile. Therefor the functionality can only be verified when the user is created, not when the user is udpated. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.create_login_profile https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.update_login_profile retval of update_login_profile is just 0.0s create_or_update_user: {'ResponseMetadata': {'HTTPHeaders': {'content-length': '216', 'content-type': 'text/xml', 'date': 'Wed, 12 Jan 2022 20:18:08 GMT', 'x-amzn-requestid': '11b6fde3-9f28-4265-8fac-88e3f5a238d3'}, 'HTTPStatusCode': 200, 'RequestId': '11b6fde3-9f28-4265-8fac-88e3f5a238d3', 'RetryAttempts': 0}} Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c0b3e1b
goneri
pushed a commit
to GomathiselviS/amazon.aws
that referenced
this pull request
Sep 22, 2022
add missing password_reset_required parameter SUMMARY password_reset_required parameter is missing in iam_user module. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_user ADDITIONAL INFORMATION Sadly, LoginProfile is only returned on create_login_profile and not on update_login_profile. Therefor the functionality can only be verified when the user is created, not when the user is udpated. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.create_login_profile https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.update_login_profile retval of update_login_profile is just 0.0s create_or_update_user: {'ResponseMetadata': {'HTTPHeaders': {'content-length': '216', 'content-type': 'text/xml', 'date': 'Wed, 12 Jan 2022 20:18:08 GMT', 'x-amzn-requestid': '11b6fde3-9f28-4265-8fac-88e3f5a238d3'}, 'HTTPStatusCode': 200, 'RequestId': '11b6fde3-9f28-4265-8fac-88e3f5a238d3', 'RetryAttempts': 0}} Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c0b3e1b
1 task
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
add missing password_reset_required parameter SUMMARY password_reset_required parameter is missing in iam_user module. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_user ADDITIONAL INFORMATION Sadly, LoginProfile is only returned on create_login_profile and not on update_login_profile. Therefor the functionality can only be verified when the user is created, not when the user is udpated. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.create_login_profile https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.update_login_profile retval of update_login_profile is just 0.0s create_or_update_user: {'ResponseMetadata': {'HTTPHeaders': {'content-length': '216', 'content-type': 'text/xml', 'date': 'Wed, 12 Jan 2022 20:18:08 GMT', 'x-amzn-requestid': '11b6fde3-9f28-4265-8fac-88e3f5a238d3'}, 'HTTPStatusCode': 200, 'RequestId': '11b6fde3-9f28-4265-8fac-88e3f5a238d3', 'RetryAttempts': 0}} Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
add missing password_reset_required parameter SUMMARY password_reset_required parameter is missing in iam_user module. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_user ADDITIONAL INFORMATION Sadly, LoginProfile is only returned on create_login_profile and not on update_login_profile. Therefor the functionality can only be verified when the user is created, not when the user is udpated. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.create_login_profile https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.update_login_profile retval of update_login_profile is just 0.0s create_or_update_user: {'ResponseMetadata': {'HTTPHeaders': {'content-length': '216', 'content-type': 'text/xml', 'date': 'Wed, 12 Jan 2022 20:18:08 GMT', 'x-amzn-requestid': '11b6fde3-9f28-4265-8fac-88e3f5a238d3'}, 'HTTPStatusCode': 200, 'RequestId': '11b6fde3-9f28-4265-8fac-88e3f5a238d3', 'RetryAttempts': 0}} Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
add missing password_reset_required parameter SUMMARY password_reset_required parameter is missing in iam_user module. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_user ADDITIONAL INFORMATION Sadly, LoginProfile is only returned on create_login_profile and not on update_login_profile. Therefor the functionality can only be verified when the user is created, not when the user is udpated. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.create_login_profile https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.update_login_profile retval of update_login_profile is just 0.0s create_or_update_user: {'ResponseMetadata': {'HTTPHeaders': {'content-length': '216', 'content-type': 'text/xml', 'date': 'Wed, 12 Jan 2022 20:18:08 GMT', 'x-amzn-requestid': '11b6fde3-9f28-4265-8fac-88e3f5a238d3'}, 'HTTPStatusCode': 200, 'RequestId': '11b6fde3-9f28-4265-8fac-88e3f5a238d3', 'RetryAttempts': 0}} Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #686.
Current return value of _format_listener method does not include
SSLCertificateIdeven if it is provided in the playbook, causing the failure as reported in above mentioned issue.Sample return value:
This can be fixed by modifying the return value of _format_listener method to formatted_listener, which includes
SSLCertificateIdif provided in the playbook.Sample return Value:
ISSUE TYPE
COMPONENT NAME
elb_classic_lb