ec2_eni: change data type of device_index to str when passing it to api as expected by api call
#877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
mandar242
changed the title
device_index to str as expected by api calldevice_index to str when passing it to api as expected by api call
tremble
reviewed
Jun 17, 2022
jillr
reviewed
Jun 17, 2022
ansibullbot
added
integration
alinabuzachis
approved these changes
Jun 22, 2022
tremble
approved these changes
Jun 22, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
jatorcasso
pushed a commit
to jatorcasso/amazon.aws
that referenced
this pull request
Jun 27, 2022
… api as expected by api call (ansible-collections#877) ec2_eni: change data type of `device_index` to str when passing it to api as expected by api call SUMMARY Currently the data type for parameter device_index here while being passed to api call is integer but one of the API calls later used here in the module (describe_network_interfaces) expects it to be string as per boto3 api documentation. Fixes ansible-collections#870 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_eni Reviewed-by: Mark Chappell <None> Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None>
1 task
1 task
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
cloudfront_distribution: add missing documentation SUMMARY Closes ansible-collections#877 The modul resprects this parameter already. ISSUE TYPE Docs Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
cloudfront_distribution: add missing documentation SUMMARY Closes ansible-collections#877 The modul resprects this parameter already. ISSUE TYPE Docs Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
cloudfront_distribution: add missing documentation SUMMARY Closes ansible-collections#877 The modul resprects this parameter already. ISSUE TYPE Docs Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently the data type for parameter
device_indexhere while being passed to api call is integer but one of the API calls later used here in the module (describe_network_interfaces) expects it to bestringas per boto3 api documentation.Fixes #870
ISSUE TYPE
COMPONENT NAME
ec2_eni