Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 - remove deprecated S3_URL alias #908

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 30, 2022

SUMMARY

Remove the deprecated alias, this has been causing problems with the docs

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

s3_bucket
s3_object

ADDITIONAL INFORMATION

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jun 30, 2022
@github-actions
Copy link

github-actions bot commented Jun 30, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have a changelog fragment for the removal?

@tremble
Copy link
Contributor Author

tremble commented Jun 30, 2022

Yes, I wanted to trigger the sanity tests though :) It's in my local copy and I'll push once the tests complete

@softwarefactory-project-zuul

This comment was marked as resolved.

@ansibullbot ansibullbot added tests tests and removed owner_pr PR created by owner/maintainer labels Jun 30, 2022
@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul

This comment was marked as outdated.

@softwarefactory-project-zuul

This comment was marked as outdated.

@ansibullbot ansibullbot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Jun 30, 2022
@ansibullbot ansibullbot added community_review and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jun 30, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 48s
✔️ build-ansible-collection SUCCESS in 5m 09s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 13s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 31s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 15s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 52s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 59s
✔️ ansible-test-splitter SUCCESS in 2m 33s
✔️ integration-amazon.aws-1 SUCCESS in 14m 13s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble requested a review from jatorcasso June 30, 2022 14:48
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 30, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 34s
✔️ build-ansible-collection SUCCESS in 5m 40s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 10s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 12m 47s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 04s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 42s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 57s
✔️ ansible-test-splitter SUCCESS in 2m 58s
✔️ integration-amazon.aws-1 SUCCESS in 12m 22s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d8dd88c into ansible-collections:main Jun 30, 2022
@tremble tremble deleted the deprecations/5.0.0/S3_URL branch September 9, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants