Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default value for purge_tags #916

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 6, 2022

SUMMARY

Update purge_tags default value to True for various modules.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/ec2_ami.py
plugins/modules/ec2_instance.py
plugins/modules/ec2_key.py
plugins/modules/ec2_vol.py
plugins/modules/ec2_vpc_endpoint.py
plugins/modules/ec2_vpc_net.py
plugins/modules/ec2_vpc_route_table.py

ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jul 6, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 07s
✔️ build-ansible-collection SUCCESS in 4m 48s
ansible-test-sanity-aws-ansible-python38 FAILURE in 11m 10s
ansible-test-sanity-aws-ansible-2.12-python38 FAILURE in 8m 51s
ansible-test-sanity-aws-ansible-2.13-python38 FAILURE in 9m 36s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 03s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 47s
✔️ ansible-test-splitter SUCCESS in 2m 34s
integration-amazon.aws-1 FAILURE in 30m 11s
integration-amazon.aws-2 TIMED_OUT in 1h 00m 44s
integration-amazon.aws-3 FAILURE in 28m 29s
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 7m 32s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble force-pushed the deprecations/5.0.0/purge_tags branch from 31ba275 to 0d463d8 Compare July 6, 2022 13:33
@ansibullbot ansibullbot added integration tests/integration tests tests and removed owner_pr PR created by owner/maintainer labels Jul 6, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 5m 03s
✔️ build-ansible-collection SUCCESS in 4m 59s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 43s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 40s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 47s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 44s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 41s
✔️ ansible-test-splitter SUCCESS in 2m 40s
✔️ integration-amazon.aws-1 SUCCESS in 20m 27s
integration-amazon.aws-2 TIMED_OUT in 1h 00m 44s
✔️ integration-amazon.aws-3 SUCCESS in 29m 58s
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 5m 19s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble
Copy link
Contributor Author

tremble commented Jul 6, 2022

recheck

@tremble tremble force-pushed the deprecations/5.0.0/purge_tags branch from 24f595e to 6fc9397 Compare July 6, 2022 15:50
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 5m 36s
✔️ build-ansible-collection SUCCESS in 5m 46s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 50s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 52s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 25s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 45s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 08s
✔️ ansible-test-splitter SUCCESS in 3m 34s
✔️ integration-amazon.aws-1 SUCCESS in 19m 25s
integration-amazon.aws-2 TIMED_OUT in 1h 00m 50s
✔️ integration-amazon.aws-3 SUCCESS in 29m 23s
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 8m 06s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble force-pushed the deprecations/5.0.0/purge_tags branch from 6fc9397 to 6f8a380 Compare July 6, 2022 18:07
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 20s
✔️ build-ansible-collection SUCCESS in 4m 51s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 10s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 26s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 00s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 51s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 49s
✔️ ansible-test-splitter SUCCESS in 3m 09s
✔️ integration-amazon.aws-1 SUCCESS in 17m 51s
✔️ integration-amazon.aws-2 SUCCESS in 40m 26s
✔️ integration-amazon.aws-3 SUCCESS in 29m 39s
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 8m 28s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble marked this pull request as ready for review July 6, 2022 20:15
@tremble tremble requested review from alinabuzachis and jatorcasso and removed request for alinabuzachis July 6, 2022 20:15
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 7, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 5m 03s
✔️ build-ansible-collection SUCCESS in 5m 22s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 32s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 27s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 33s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 12s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 49s
✔️ ansible-test-splitter SUCCESS in 2m 31s
✔️ integration-amazon.aws-1 SUCCESS in 17m 26s
✔️ integration-amazon.aws-2 SUCCESS in 30m 06s
✔️ integration-amazon.aws-3 SUCCESS in 28m 49s
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 86a1c1f into ansible-collections:main Jul 7, 2022
@tremble tremble deleted the deprecations/5.0.0/purge_tags branch September 9, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants