ec2_vpc_route_table: Add support for Route entry for Carrier Gateway #926
Conversation
ansibullbot
added
community_review
feature
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
There was a problem hiding this comment.
Thanks for this, once we've got ansible-collections/community.aws#1353 merged we should probably update the integration tests for this module.
While the code looks good, I've not got Wavelength set up in my test environments yet, so I can't verify that this change actually works.
There was a problem hiding this comment.
While the new modules over in community.aws don't need a changelog fragment (it's automatic when a module's added), we will need a changelog fragment for this PR: https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
|
@tremble do you think we are fine to move on this PR as ansible-collections/community.aws#1353 have been merged? |
mtulio
force-pushed
the
fix-ec2-vpc-rtb-cagw
branch
from
5f23199
to
4a5671c
Compare
|
/assign @tremble |
There was a problem hiding this comment.
2 minor things,
- version_added
- changelog fragment - https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
Have you been able to test this? I'm about 90% sure this is right, but don't have an environment with Carrier Gateways
Yep, I tested when I submitted. I need to set the environment back to test both new modules again and provide logs if you consider we need it here. |
|
I'm happy enough with the change as long as we get the changelog fragment in there. |
mtulio
changed the title
mtulio
changed the title
…ection-amazon.aws into fix-ec2-vpc-rtb-cagw
Done, lmk wdyt. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 00s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 25s |
SUMMARY
Add support for VPC Carrear Gateways entry on route table.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Support Carrier Gateway route on Route Table module using the same strategy of Nat GW, discovering the prefix of resource name
cagw-.Not directly related, but testing in the same solution the cagw modules: ansible-collections/community.aws#1353