Minor linting fixups - 2022-08-04 #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
linting/2022-08-04
branch
from
018ce83
to
b1512c9
Compare
ansibullbot
added
community_review
feature
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
linting/2022-08-04
branch
from
b1512c9
to
bc85d19
Compare
jillr
approved these changes
Aug 9, 2022
goneri
approved these changes
Aug 9, 2022
tremble
added
mergeit
This comment was marked as outdated.
This comment was marked as outdated.
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
Minor linting fixups - 2022-08-08 SUMMARY Minor linting fixups docs unused variables ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/inventory/aws_ec2.py plugins/inventory/aws_rds.py plugins/lookup/aws_account_attribute.py plugins/lookup/aws_secret.py plugins/lookup/aws_ssm.py plugins/module_utils/rds.py tests/unit/plugins/inventory/test_aws_ec2.py ADDITIONAL INFORMATION Split from #953 due to integration test timeouts in community.aws Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
patchback bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
Minor linting fixups - 2022-08-08 SUMMARY Minor linting fixups docs unused variables ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/inventory/aws_ec2.py plugins/inventory/aws_rds.py plugins/lookup/aws_account_attribute.py plugins/lookup/aws_secret.py plugins/lookup/aws_ssm.py plugins/module_utils/rds.py tests/unit/plugins/inventory/test_aws_ec2.py ADDITIONAL INFORMATION Split from #953 due to integration test timeouts in community.aws Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> (cherry picked from commit 4780226)
This comment was marked as outdated.
This comment was marked as outdated.
|
regate |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Aug 10, 2022
[PR #958/47802269 backport][stable-4] Minor linting fixups - 2022-08-08 This is a backport of PR #958 as merged into main (4780226). SUMMARY Minor linting fixups docs unused variables ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/inventory/aws_ec2.py plugins/inventory/aws_rds.py plugins/lookup/aws_account_attribute.py plugins/lookup/aws_secret.py plugins/lookup/aws_ssm.py plugins/module_utils/rds.py tests/unit/plugins/inventory/test_aws_ec2.py ADDITIONAL INFORMATION Split from #953 due to integration test timeouts in community.aws Reviewed-by: Mark Chappell <None>
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
linting/2022-08-04
branch
from
bc85d19
to
a8c50b2
Compare
tremble
force-pushed
the
linting/2022-08-04
branch
from
a8c50b2
to
b9b7a1e
Compare
|
regate |
Backport to stable-4: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply ffd8c1a on top of patchback/backports/stable-4/ffd8c1a328f13df2385239a0826c8cb84e519c27/pr-953 Backporting merged PR #953 into main
🤖 @patchback |
tremble
added a commit
to tremble/amazon.aws
that referenced
this pull request
Aug 11, 2022
##### SUMMARY Minor linting fixups - docs - unused variables ##### ISSUE TYPE Feature Pull Request ##### COMPONENT NAME plugins/inventory/aws_ec2.py plugins/inventory/aws_rds.py plugins/lookup/aws_account_attribute.py plugins/lookup/aws_secret.py plugins/lookup/aws_ssm.py plugins/module_utils/acm.py plugins/module_utils/botocore.py plugins/module_utils/cloud.py plugins/module_utils/iam.py plugins/module_utils/modules.py plugins/module_utils/rds.py ##### ADDITIONAL INFORMATION Original PR Reviewed-by: Jill R Reviewed-by: Gonéri Le Bouder
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
[PR #953 backport][stable-4] Minor linting fixups - 2022-08-04 SUMMARY Minor linting fixups docs unused variables ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/inventory/aws_ec2.py plugins/inventory/aws_rds.py plugins/lookup/aws_account_attribute.py plugins/lookup/aws_secret.py plugins/lookup/aws_ssm.py plugins/module_utils/acm.py plugins/module_utils/botocore.py plugins/module_utils/cloud.py plugins/module_utils/iam.py plugins/module_utils/modules.py plugins/module_utils/rds.py ADDITIONAL INFORMATION Original PR Reviewed-by: Jill R Reviewed-by: Gonéri Le Bouder Reviewed-by: Alina Buzachis <None>
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Minor linting fixups
ISSUE TYPE
COMPONENT NAME
plugins/inventory/aws_ec2.py
plugins/inventory/aws_rds.py
plugins/lookup/aws_account_attribute.py
plugins/lookup/aws_secret.py
plugins/lookup/aws_ssm.py
plugins/module_utils/acm.py
plugins/module_utils/botocore.py
plugins/module_utils/cloud.py
plugins/module_utils/iam.py
plugins/module_utils/modules.py
plugins/module_utils/rds.py
ADDITIONAL INFORMATION