Minor Linting fixups - 2022-08-05 #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ansibullbot
added
integration
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
goneri
approved these changes
Aug 9, 2022
goneri
reviewed
Aug 9, 2022
| @@ -0,0 +1,2 @@ | |||
| breaking_changes: | |||
There was a problem hiding this comment.
It may be nice to isolate this specific change in a different PR.
There was a problem hiding this comment.
I'll strip it from the backports
tremble
added
mergeit
Backport to stable-4: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply dd0bdcc on top of patchback/backports/stable-4/dd0bdcc099416a64bc9fb7d34ffc968274c46637/pr-954 Backporting merged PR #954 into main
🤖 @patchback |
tremble
added a commit
to tremble/amazon.aws
that referenced
this pull request
Aug 10, 2022
…tions#954) Manual backport of ansible-collections#954 Minor linting fixups - docs linting and cleanup - unused variables - unused import - "mutually_exclusive" which was accidentally dropped on the floor. Feature Pull Request plugins/modules/cloudformation.py plugins/modules/ec2_eni.py plugins/modules/ec2_eni_info.py plugins/modules/ec2_instance.py plugins/modules/ec2_security_group.py plugins/modules/ec2_vol.py plugins/modules/ec2_vol_info.py plugins/modules/ec2_vpc_dhcp_option.py plugins/modules/ec2_vpc_net.py plugins/modules/ec2_vpc_subnet.py plugins/modules/elb_classic_lb.py plugins/modules/s3_bucket.py plugins/modules/s3_object.py Removes some documentation references to old "versions", these were Ansible versions which are long out of support. CloudFormations module previously talked about keeping boto3 and botocore up to date. Now that we have an official policy around supported versions this is no longer as relevant and the module itself is no longer changing as fast. Reviewed-by: Gonéri Le Bouder
tremble
added a commit
to tremble/amazon.aws
that referenced
this pull request
Aug 10, 2022
…tions#954) Manual backport of ansible-collections#954 Minor linting fixups - docs linting and cleanup - unused variables - unused import - "mutually_exclusive" which was accidentally dropped on the floor. Feature Pull Request plugins/modules/cloudformation.py plugins/modules/ec2_eni.py plugins/modules/ec2_eni_info.py plugins/modules/ec2_instance.py plugins/modules/ec2_security_group.py plugins/modules/ec2_vol.py plugins/modules/ec2_vol_info.py plugins/modules/ec2_vpc_dhcp_option.py plugins/modules/ec2_vpc_net.py plugins/modules/ec2_vpc_subnet.py plugins/modules/elb_classic_lb.py plugins/modules/s3_bucket.py plugins/modules/s3_object.py Removes some documentation references to old "versions", these were Ansible versions which are long out of support. CloudFormations module previously talked about keeping boto3 and botocore up to date. Now that we have an official policy around supported versions this is no longer as relevant and the module itself is no longer changing as fast. Reviewed-by: Gonéri Le Bouder
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
[PR #954 backport][stable-4] Minor Linting fixups - 2022-08-05 Manual backport of #954 SUMMARY Minor linting fixups docs linting and cleanup unused variables unused import "mutually_exclusive" which was accidentally dropped on the floor. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/cloudformation.py plugins/modules/ec2_eni.py plugins/modules/ec2_eni_info.py plugins/modules/ec2_instance.py plugins/modules/ec2_security_group.py plugins/modules/ec2_vol.py plugins/modules/ec2_vol_info.py plugins/modules/ec2_vpc_dhcp_option.py plugins/modules/ec2_vpc_net.py plugins/modules/ec2_vpc_subnet.py plugins/modules/elb_classic_lb.py plugins/modules/s3_bucket.py plugins/modules/s3_object.py ADDITIONAL INFORMATION Removes some documentation references to old "versions", these were Ansible versions which are long out of support. CloudFormations module previously talked about keeping boto3 and botocore up to date. Now that we have an official policy around supported versions this is no longer as relevant and the module itself is no longer changing as fast. Reviewed-by: Gonéri Le Bouder Reviewed-by: Alina Buzachis <None>
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Minor linting fixups
ISSUE TYPE
COMPONENT NAME
plugins/modules/cloudformation.py
plugins/modules/ec2_eni.py
plugins/modules/ec2_eni_info.py
plugins/modules/ec2_instance.py
plugins/modules/ec2_security_group.py
plugins/modules/ec2_vol.py
plugins/modules/ec2_vol_info.py
plugins/modules/ec2_vpc_dhcp_option.py
plugins/modules/ec2_vpc_net.py
plugins/modules/ec2_vpc_subnet.py
plugins/modules/elb_classic_lb.py
plugins/modules/s3_bucket.py
plugins/modules/s3_object.py
ADDITIONAL INFORMATION
Removes some documentation references to old "versions", these were Ansible versions which are long out of support.
CloudFormations module previously talked about keeping boto3 and botocore up to date. Now that we have an official policy around supported versions this is no longer as relevant and the module itself is no longer changing as fast.