Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor sanity test fixes (new devel) #968

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Aug 12, 2022

SUMMARY

ansible-devel has added a new PEP test (missing whitespace after keyword), this adds the fixes before the devel sanity tests are 'voting'.

Additionally fixes:

  • unused variables
  • broad catching of Exception
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/action/s3_object.py
plugins/module_utils/elbv2.py
plugins/module_utils/waf.py
plugins/modules/aws_caller_info.py
plugins/modules/cloudformation.py
plugins/modules/ec2_metadata_facts.py
plugins/modules/ec2_security_group.py
plugins/modules/ec2_vpc_endpoint.py
plugins/modules/ec2_vpc_nat_gateway.py

ADDITIONAL INFORMATION

@tremble tremble changed the title Minor sanity test fixes - new devel sanity tests Minor sanity test fixes (new devel) Aug 12, 2022
@ansibullbot ansibullbot added action action plugin bug This issue/PR relates to a bug community_review module module module_utils module_utils needs_triage plugins plugin (any type) labels Aug 12, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 03s
✔️ build-ansible-collection SUCCESS in 5m 11s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 41s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 19s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 39s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 12s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 4m 58s
✔️ ansible-test-splitter SUCCESS in 2m 39s
✔️ integration-amazon.aws-1 SUCCESS in 12m 42s
✔️ integration-amazon.aws-2 SUCCESS in 15m 51s
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 8m 43s
✔️ integration-community.aws-2 SUCCESS in 24m 37s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 12s

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Aug 15, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 3m 43s
✔️ build-ansible-collection SUCCESS in 4m 53s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 20s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 26s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 11s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 04s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 08s
✔️ ansible-test-splitter SUCCESS in 2m 28s
✔️ integration-amazon.aws-1 SUCCESS in 11m 55s
✔️ integration-amazon.aws-2 SUCCESS in 16m 39s
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 7m 51s
✔️ integration-community.aws-2 SUCCESS in 26m 08s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 33s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 315472a into ansible-collections:main Aug 15, 2022
@tremble tremble deleted the sanity/2022-08-12 branch September 9, 2022 08:49
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ble-collections#970)

redshift_info - fix invalid import path for botocore exceptions

Depends-On: ansible-collections#979
SUMMARY



Fix invalid import path for botocore exceptions
Fixes ansible-collections#968

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME
redshift_info

Reviewed-by: Mark Woolley <mw@marknet15.com>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ble-collections#970)

redshift_info - fix invalid import path for botocore exceptions

Depends-On: ansible-collections#979
SUMMARY



Fix invalid import path for botocore exceptions
Fixes ansible-collections#968

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME
redshift_info

Reviewed-by: Mark Woolley <mw@marknet15.com>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…ble-collections#970)

redshift_info - fix invalid import path for botocore exceptions

Depends-On: ansible-collections#979
SUMMARY



Fix invalid import path for botocore exceptions
Fixes ansible-collections#968

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME
redshift_info

Reviewed-by: Mark Woolley <mw@marknet15.com>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action action plugin bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module_utils module_utils module module needs_triage plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants