'csh' shell plugin is broken with 'become'

[Akasurde]

From @agaffney on Mar 15, 2020 23:04

SUMMARY

Using the csh shell plugin with become enabled causes an error. This error is due to code in plugins/become/__init__.py referencing the ECHO and COMMAND_SEP vars from the shell plugin class, which are only defined in plugins/shell/sh.py and those plugins that inherit from it. This has probably been broken for a while.

ISSUE TYPE

• Bug Report

COMPONENT NAME

csh shell plugin

ANSIBLE VERSION

ansible 2.9.6

CONFIGURATION

N/A

OS / ENVIRONMENT

N/A

STEPS TO REPRODUCE

$ ansible localhost -e ansible_shell_type=csh -b -a echo
localhost | FAILED | rc=-1 >>
The csh shell family is incompatible with the sudo become plugin

EXPECTED RESULTS

N/A

ACTUAL RESULTS

N/A

Copied from original issue: ansible/ansible#68241