Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhel_facts module must use keyword arguments #434

Conversation

richm
Copy link
Contributor

@richm richm commented Mar 23, 2023

SUMMARY

The rhel_facts module must use keyword arguments. The current
code gives this error:

Traceback (most recent call last):
...
  File "/tmp/ansible_ansible.posix.rhel_facts_payload_y10oy_4m/.../rhel_facts.py", line 72, in main
  TypeError: exit_json() takes 1 positional argument but 2 were given

The fix is to use all keyword arguments like other facts plugins.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible.posix.rhel_facts

ADDITIONAL INFORMATION

@maxamillion fyi

The rhel_facts module must use keyword arguments.  The current
code gives this error:
```
Traceback (most recent call last):
...
  File "/tmp/ansible_ansible.posix.rhel_facts_payload_y10oy_4m/.../rhel_facts.py", line 72, in main
  TypeError: exit_json() takes 1 positional argument but 2 were given
```
The fix is to use all keyword arguments like other facts plugins.
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b70173a05da0455d9264a2d4094e243f

ansible-changelog-fragment FAILURE in 12s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 09s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 52s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 9m 29s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 8m 14s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 15s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 57s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 6m 45s
✔️ ansible-test-units-posix-python39 SUCCESS in 5m 59s
✔️ ansible-test-units-posix-python310 SUCCESS in 7m 18s
✔️ ansible-galaxy-importer SUCCESS in 3m 23s
✔️ build-ansible-collection SUCCESS in 6m 37s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f7430a6c04694937a4c35b0d0fd67018

✔️ ansible-changelog-fragment SUCCESS in 12s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 38s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 27s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 43s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 9m 02s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 36s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 06s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 16s
✔️ ansible-test-units-posix-python39 SUCCESS in 6m 53s
✔️ ansible-test-units-posix-python310 SUCCESS in 7m 21s
✔️ ansible-galaxy-importer SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 6m 34s

Copy link
Collaborator

@saito-hideki saito-hideki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM.

@saito-hideki saito-hideki added the mergeit Gate PR in Zuul CI label Mar 24, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/b9381a1ecf804e13a97f298bfbfcbd25

✔️ ansible-changelog-fragment SUCCESS in 13s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 27s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 50s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 40s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 10m 26s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 14m 06s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 31s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 59s
✔️ ansible-test-units-posix-python39 SUCCESS in 5m 14s
✔️ ansible-test-units-posix-python310 SUCCESS in 5m 15s
✔️ ansible-galaxy-importer SUCCESS in 3m 44s
✔️ build-ansible-collection SUCCESS in 6m 33s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ab94cc7 into ansible-collections:main Mar 24, 2023
82 checks passed
@richm richm mentioned this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Gate PR in Zuul CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants