New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rhel_facts module must use keyword arguments #434
rhel_facts module must use keyword arguments #434
Conversation
The rhel_facts module must use keyword arguments. The current code gives this error: ``` Traceback (most recent call last): ... File "/tmp/ansible_ansible.posix.rhel_facts_payload_y10oy_4m/.../rhel_facts.py", line 72, in main TypeError: exit_json() takes 1 positional argument but 2 were given ``` The fix is to use all keyword arguments like other facts plugins.
Build failed. ❌ ansible-changelog-fragment FAILURE in 12s |
Build succeeded. ✔️ ansible-changelog-fragment SUCCESS in 12s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! LGTM.
Build succeeded (gate pipeline). ✔️ ansible-changelog-fragment SUCCESS in 13s |
ab94cc7
into
ansible-collections:main
SUMMARY
The rhel_facts module must use keyword arguments. The current
code gives this error:
The fix is to use all keyword arguments like other facts plugins.
ISSUE TYPE
COMPONENT NAME
ansible.posix.rhel_facts
ADDITIONAL INFORMATION
@maxamillion fyi