Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving ipaddr from ansible.netcommon to ansible.utils breaks stuff #148

Closed
sebastianw opened this issue Mar 2, 2022 · 1 comment · Fixed by #149
Closed

Moving ipaddr from ansible.netcommon to ansible.utils breaks stuff #148

sebastianw opened this issue Mar 2, 2022 · 1 comment · Fixed by #149
Assignees
@ashwini-mhatre

Comments

@sebastianw
Copy link
Contributor

sebastianw commented Mar 2, 2022 •
edited
Loading

SUMMARY

When the ipaddr filter moved from ansible.netcommon to ansible.utils it changed behaviour and breaks downstream usage.

ISSUE TYPE
  • Bug Report
COMPONENT NAME

ipaddr

For more information see ansible-collections/ansible.netcommon#375
@ashwini-mhatre ashwini-mhatre self-assigned this Mar 2, 2022
@ashwini-mhatre ashwini-mhatre mentioned this issue Mar 2, 2022
Merged
ansible-zuul bot pushed a commit that referenced this issue Mar 4, 2022
@ashwini-mhatre
Fix bugs in Ipaddr filters (#149)
0716010 
Fix bugs in Ipaddr filters

SUMMARY

ipaddr - Fix input validation issues in ipaddr,ipv4,ipv6,ipwrap filters.
ipaddr - Add valid network for link-local
fixes: #148
fixes: ansible-collections/ansible.netcommon#375
fixes: ansible-collections/ansible.netcommon#350

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: Sagar Paul <sagpaul@redhat.com>
@AdamMack2007 AdamMack2007 mentioned this issue Mar 4, 2022
Closed
This was referenced Mar 10, 2022
Closed
Merged
@ashwini-mhatre
Copy link
Contributor

We have released utils 2.5.2 and netcommon 2.6.1 which fixed ansible-collections/ansible.netcommon#375 and #148 issues.

For FQDN issue ansible-core team already merged ansible/ansible#77210. This fix will be available in 28th march release.

which means,
For non fqdn ipaddr filters users can use old netcommon collection version 2.5.1 as workaround until core-team will release ansible code(28th march). For fqdn ipaddr filters users can use latest versions of any of netcommon(2.6.1) or utils(2.5.2) cc: @trishnaguha

@renovate renovate bot mentioned this issue Mar 15, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashwini-mhatre ashwini-mhatre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bugs in Ipaddr filters ashwini-mhatre/ansible.utils
2 participants
@sebastianw @ashwini-mhatre