Add documentation for IPv6 in ipsubnet filter. Add unit tests #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastien-rosset
changed the title
|
@sebastien-rosset could you please open those bugs as separate issues? |
sebastien-rosset
force-pushed
the
ipv6_ipsubnet
branch
from
e97d539
to
acf52be
Compare
|
Unable to freeze job graph: Job network-ee-unit-tests depends on network-ee-build-container-image which was not run. |
sebastien-rosset
commented
Feb 2, 2022
|
Unable to freeze job graph: Job network-ee-unit-tests depends on network-ee-build-container-image which was not run. |
|
Unable to freeze job graph: Job network-ee-unit-tests depends on network-ee-build-container-image which was not run. |
sebastien-rosset
force-pushed
the
ipv6_ipsubnet
branch
from
aa0af9f
to
db31e44
Compare
|
Unable to freeze job graph: Job network-ee-unit-tests depends on network-ee-build-container-image which was not run. |
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
recheck |
|
@sebastien-rosset This will be trivial change instead of minor_changes. could you please update changelog fragment? |
|
Build failed.
|
I don't see a "trivial" section in the changelogs/config.yaml file. Can you suggest a change? https://github.com/ansible-collections/ansible.utils/blob/main/changelogs/config.yaml |
That would be what |
Qalthos
requested changes
Apr 25, 2022
Co-authored-by: Nathaniel Case <this.is@nathanielca.se>
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Replaced by #212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ipsubnetfilter documentation.ipsubnetdocumentation.ipsubnetfilter.ISSUE TYPE
COMPONENT NAME
ipsubnetfilterADDITIONAL INFORMATION
Analysis
ipsubnetfilter should not construct a list of subnets, then get subnet at index X. Instead, the subnet can be constructed using bit operations.