Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the netaddr error msg for clarity #244

Merged
merged 5 commits into from
Apr 5, 2023

Conversation

roverflow
Copy link
Contributor

@roverflow roverflow commented Mar 23, 2023

SUMMARY

Fixed the netaddr package error msg from:
The ipv4 filter requires python's netaddr be installed on the ansible controller
To:
The ipv4 filter requires that the Python netaddr package be installed on the ansible controller

For better clarity

Fixing #243

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • plugins/plugin_utils/base/ipaddr_utils.py
  • plugins/plugin_utils/base/ipaddress_utils.py

@softwarefactory-project-zuul
Copy link
Contributor

@ashwini-mhatre ashwini-mhatre self-requested a review March 29, 2023 11:57
Copy link
Contributor

@Qalthos Qalthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use missing_required_lib instead so we can have a consistent messaging for missing packages.

@softwarefactory-project-zuul
Copy link
Contributor

@roverflow roverflow requested a review from Qalthos April 5, 2023 07:15
@softwarefactory-project-zuul
Copy link
Contributor

@roverflow roverflow merged commit ed65555 into ansible-collections:main Apr 5, 2023
54 checks passed
@roverflow roverflow deleted the bug/errorMsg branch April 5, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants