Add to_xml and from_xml filter plugin

[ashwini-mhatre]

SUMMARY

ISSUE TYPE

• Feature Pull Request
• Docs Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

[ganeshrn]

Also please add unit and integration tests

[cidrblock]

putting this out for conversation, does simply to_xml and from_xml make better sense as a name, since from the user perspective the actual json representation of the data is never seen since it is immediately picked up by ansible and made available as native data structure

[ashwini-mhatre]

As its only specific to json and xml conversion and xml to json i think xml_to_json and json_to_xml are valid names. if we are supporting from any data format to xml then to_xml sounds good. @cidrblock @ganeshrn please let me know your inputs on this.

[cidrblock]

I was thinking more about this pattern:

{{ some_variable | to_json }}
{{ some_variable | to_yaml }}

where the transform is being done from data ansible has (which is a python object, not specifically json)

in the case of from_xml, the user is left with a native data object as well.

WDYT ganesh?

[ganeshrn]

@cidrblock to_json \ from_yaml and from_json \ from_yaml is a conversion between json/yaml object <--> to
it's string representation but in this case we are changing the structure of data itself so IMO from_xml name might be misleading as it might refer we are returning an xml object. How about xml_to_native and native_to_xml

[ashwini-mhatre]

Also please add unit and integration tests

added uts and integration testcases

[ganeshrn]

@cidrblock @ashwini-mhatre As per your earlier comment we can rename the plugins to to_xml and from_xml with proper documentation to highlight to_xml converts native python dictionary to xmlstring and from_xml converts xml string to native python dictionary

[ashwini-mhatre]

@cidrblock @ashwini-mhatre As per your earlier comment we can rename the plugins to to_xml and from_xml with proper documentation to highlight to_xml converts native python dictionary to xmlstring and from_xml converts xml string to native python dictionary

@ganeshrn @cidrblock will rename these plugins as to_xml and from_xml.

[ashwini-mhatre]

recheck

[ashwini-mhatre]

recheck