New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eos_lag_interfaces name parameter requires 'Port-Channel' in the name despite documentation stating otherwise #79
Comments
sc68cal
added a commit
to sc68cal/arista.eos
that referenced
this issue
Jul 7, 2020
sc68cal
added a commit
to sc68cal/arista.eos
that referenced
this issue
Jul 7, 2020
sc68cal
changed the title
eos_lag_interfaces documentation mismatch
eos_lag_interfaces name parameter requires 'Port-Channel' in the name despite documentation stating otherwise
Jul 7, 2020
I have pushed a patch with code that handles both cases where only integer digits are passed to the name, as well as |
sc68cal
added a commit
to sc68cal/arista.eos
that referenced
this issue
Jul 8, 2020
sc68cal
added a commit
to sc68cal/arista.eos
that referenced
this issue
Jul 8, 2020
sc68cal
added a commit
to sc68cal/arista.eos
that referenced
this issue
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The documentation for
eos_lag_interfaces
has examples such asHowever, the code that actually appears to implement this, uses the 12th letter of the
name
parameter, forward.arista.eos/plugins/module_utils/network/eos/config/lag_interfaces/lag_interfaces.py
Line 244 in 9c38a15
So following the documentation, you end up with an error because if you create a name of just
10
like the documentation states,channel_id
turns into an empty string, which yields flawed commands and results in an errorManaully fixing this by doing
Corrects this issue.
So which is the correct fix? Documentation fix, or better code?
The text was updated successfully, but these errors were encountered: