Enable http server at the end of eos_eapi tests #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GomathiselviS <gomathiselvi@gmail.com>
Qalthos
reviewed
Jun 1, 2021
| assert: | ||
| that: | ||
| - http_config.stdout[0].httpServer.port == 80 | ||
|
|
||
| - name: Expect endpoint other ports to be set as configured | ||
| assert: |
There was a problem hiding this comment.
I don't know that there is much value in breaking this down into two separate assert statements. A longer name or even just a comment before the assert task would be fine for me
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY
HTTP server is disabled as part of eos_eapi test configure.yaml. This PR enables the server at the end of the test.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION