Use creds in module args when auth_source is auto #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When service principals are specified in the module arguments
(subscription_id, tenant, client_id, secret) and auth_type is auto,
azure_rm_keyvaultkey, azure_rm_keyvaultkey_info,
azure_rm_keyvaultsecret, azure_rm_keyvaultsecret_info first attempted to
use credentials from env and the disk and only use the specified
credentials if not found.
To reproduce, specify a service principal in `cloud-config-azure.ini`
and run:
`ansible-test integration azure_rm_keyvaultsecret --allow-destructive`
The test will succeed. Then, do an `az login` and re-run the above
command. The test will fail. Delete your cached credentials:
`rm ~/.azure/msal_token_cache.json`
Run the test again. The test will succeed.
c.f. ansible-collections#1009
Fred-sun
added
medium_priority
Fred-sun
added
ready_for_review
xuzhang3
approved these changes
May 30, 2023
|
@markscottwright LGTM 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When service principals are specified in the module arguments (subscription_id, tenant, client_id, secret) and auth_type is auto, azure_rm_keyvaultkey, azure_rm_keyvaultkey_info, azure_rm_keyvaultsecret, azure_rm_keyvaultsecret_info first attempted to use credentials from env and the disk and only use the specified credentials if not found.
Fixes #1009
ISSUE TYPE
COMPONENT NAME
azure_rm_keyvaultkey
azure_rm_keyvaultkey_info
azure_rm_keyvaultsecret
azure_rm_keyvaultsecret_info
ADDITIONAL INFORMATION
To reproduce, specify a service principal in
cloud-config-azure.iniand run:The test will succeed. Then, do an
az loginand re-run the above command. The test will fail. Delete your cached credentials:Run the test again. The test will succeed.