azure_rm_virtualmachine: add option to choose whether or not to create a network security group #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
reviewed
Dec 26, 2022
| if self.created_nsg: | ||
| self.results['actions'].append('Created default security group {0}'.format(self.name + '01')) | ||
| group = self.create_default_securitygroup(self.resource_group, self.location, self.name + '01', self.os_type, | ||
| self.open_ports) |
There was a problem hiding this comment.
continuation line under-indented for visual indent
There was a problem hiding this comment.
@Fred-sun thank you for review. I fixed it.
| group = self.create_default_securitygroup(self.resource_group, self.location, self.name + '01', self.os_type, | ||
| self.open_ports) | ||
| parameters.network_security_group = self.network_models.NetworkSecurityGroup(id=group.id, | ||
| location=group.location, |
There was a problem hiding this comment.
2392 and 2393 line continuation line under-indented for visual indent
There was a problem hiding this comment.
@Fred-sun I fixed it, too.
Fred-sun
added
medium_priority
Fred-sun
added
ready_for_review
|
Is there anything I should do to merge? |
|
@akira6592 We have recently considered a new release and will consider incorporating this change! Thanks! |
xuzhang3
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently, if
network_interface_namesis not specified, a network security group is created and attached to a default network interface .This PR will add option that allow you to choose whether or not to create a network security group. The default value is
True, so the network security group is created as before. IfFalseis specified, the network security group will not be created.This is intended for use cases where network security groups are connected to subnets.
ISSUE TYPE
COMPONENT NAME
azure_rm_virtualmachineADDITIONAL INFORMATION