azure_rm_securitygroup: improve idempotency for protocol #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
added
ready_for_review
xuzhang3
approved these changes
Jan 12, 2023
|
@akira6592 LGTM |
|
Thank you for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
If you enter the protocol name from the Azure Portal, it will be uppercase (e.g. TCP).On the other hands, azure_rm_securitygroup module can specify protocol with capitalized (e.g. Tcp).
Due to this difference unintentional
changedoccurs.This PR allows to diff protocol name by case-insensitive for improving idempotency.
ISSUE TYPE
COMPONENT NAME
azure_rm_securitygroupmoduleADDITIONAL INFORMATION
Added a test to verify that from a state with rules using
TCP, running the same rules in the azure_rm_securitygroup module specifyingTcpdoes not result in changed. It works fine by my environment.