Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_message_size_in_kilobytes to azure_rm_servicebusqueue.py #1092

Merged

Conversation

Fred-sun
Copy link
Collaborator

SUMMARY

Add max_message_size_in_kilobytes to azure_rm_servicebustopic.py and azure_rm_servicebusqueue.py, try to fix #1003

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_servicebustopic.py
azure_rm_servicebusqueue.py

ADDITIONAL INFORMATION

@madmalkav
Copy link

Description on all files seems to be wrong? Browsing from my phone so not sure I’m looking at at correctly

@Fred-sun
Copy link
Collaborator Author

Description on all files seems to be wrong? Browsing from my phone so not sure I’m looking at at correctly

@madmalkav Thanks for your check! Already update!

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority work in In trying to solve, or in working with contributors and removed work in In trying to solve, or in working with contributors labels Feb 24, 2023
xuzhang3
xuzhang3 previously approved these changes Apr 6, 2023
@xuzhang3 xuzhang3 merged commit d8f0593 into ansible-collections:dev Apr 6, 2023
@Fred-sun Fred-sun deleted the Add_max_message_size_in_kilobytes branch April 24, 2023 03:24
@madmalkav
Copy link

This doesn't appear in the changelog of version 1.15.0 , has it been integrated on that version or is it waiting for a future date?

@xuzhang3
Copy link
Collaborator

@madmalkav This feature should be available in v1.15.0

@madmalkav
Copy link

madmalkav commented May 31, 2023

But it isn’t , look at the code, it is not there. 1.15.0 was release based in code from beginning of March

@xuzhang3
Copy link
Collaborator

@madmalkav Rechecked the code and release timeline, this feature not released and will be available in v1.16.0. Sorry for the inconvenience

@madmalkav
Copy link

What sense does it make to hold code that is already implemented and make customers wait for months to add support for a single parameter in an already implemented module?

This was referenced May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to set message size on azure_rm_servicebusqueue and azure_rm_servicebustopic
3 participants