Remove references to Redis 4 and support upgrading to Redis 6 #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fred-sun Hello--can you please review and advise? Thank you! |
|
@l3ender Great. Now I(redis_verison=4) is retired. |
Fred-sun
added
enhancement
|
@l3ender Redis v4 is in deprecating phase and currently v4 instance can still be updated but cannot create new instance. We should let users choose whether to upgrade to v6 not totally remove v4 support which is a breaking changed. |
Fred-sun
removed
the
ready_for_review
|
kindly ping! |
l3ender
force-pushed
the
redis-upgrade
branch
2 times, most recently
from
1753eac
to
efd89dc
Compare
|
@Fred-sun - I've updated the PR and kept support for Redis4, while setting 6 as the default and allowing upgrades from 4->6. Please review; thanks! |
Fred-sun
added
the
ready_for_review
xuzhang3
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Redis 4 is no longer being supported and existing instances need to be updated: https://azure.microsoft.com/en-us/updates/upgrade-your-azure-cache-for-redis-instances-to-use-redis-version-6-by-30-june-2023/
ISSUE TYPE
COMPONENT NAME
azure_rm_rediscache
ADDITIONAL INFORMATION
See announcement here: https://azure.microsoft.com/en-us/updates/upgrade-your-azure-cache-for-redis-instances-to-use-redis-version-6-by-30-june-2023/
Upgrading an existing instance (from 4->6) is supported (I have tested) so the module is being updated appropriately.