Migrate missing doc_fragments that went missing to this collection #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
See issue #103
This pulls in:
https://github.com/ansible/ansible/blob/stable-2.9/lib/ansible/plugins/doc_fragments/azure.py
https://github.com/ansible/ansible/blob/stable-2.9/lib/ansible/plugins/doc_fragments/azure_tags.py
ISSUE TYPE
COMPONENT NAME
doc_fragments/azure.py
doc_fragments/azure_tags.py
ADDITIONAL INFORMATION
I tried to do due diligence asking here:
ansible/ansible#67684 (comment)
About whether or not the current code in this collection will be allowed to work. There was some confusion on that point, but they have clearly answered that nothing is planned that will support the non-FQCN doc fragment. I see no way to get this fixed in any reasonable timeframe other than the collection, itself, making this change.
Example of testing this:
This renders correctly (using Ansible
devel
branch), and makes use of both doc fragments. I have also tested the inventory plugin withansible-inventory
.Ping @gundalow, because I know he has tried to do a sweep to check for items that went missing in the great collection migration. This isn't the first time this kind of situation has happened. Doc fragments were not around when several collections started out, so there's a clear story of how it got here.
if you consult the Ansible core file (the current file)
.github//BOTMETA.yml
, then you will find:So clearly it thinks that these files moved here.