Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support static IPv6 address #125

Merged

Conversation

Fred-sun
Copy link
Collaborator

@Fred-sun Fred-sun commented May 19, 2020

SUMMARY

Update azure_rm_publicipaddress model, fixes #110 .

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_publicipaddress

ADDITIONAL INFORMATION

@Fred-sun Fred-sun changed the title Update azure_rm_publicipaddress [WIP]Update azure_rm_publicipaddress May 21, 2020
@aardbol
Copy link

aardbol commented Jul 20, 2020

Your modification is wrong. This fixes the SKU issue:
public_ip_allocation_method=self.allocation_method if self.sku == 'Basic' else 'Static',

This is due to the Standard SKU only supported the Static allocation method for both IPv4 and IPv6.

Also, please don't forget to add this to the allocation_method description documentation:
- Is always Static when Standard SKU is used

@Fred-sun
Copy link
Collaborator Author

Your modification is wrong. This fixes the SKU issue:
public_ip_allocation_method=self.allocation_method if self.sku == 'Basic' else 'Static',

This is due to the Standard SKU only supported the Static allocation method for both IPv4 and IPv6.

Also, please don't forget to add this to the allocation_method description documentation:
- Is always Static when Standard SKU is used

@aardbol Thank you for your suggestion. I don't think there is any need to add judgments. What kind of parameter configuration should be used instead in the document. Thank you!

@Fred-sun Fred-sun added the ready_for_review The PR has been modified and can be reviewed and merged label Aug 24, 2020
@Fred-sun Fred-sun changed the title [WIP]Update azure_rm_publicipaddress Update azure_rm_publicipaddress Sep 3, 2020
@Fred-sun Fred-sun closed this Sep 3, 2020
@Fred-sun Fred-sun reopened this Sep 3, 2020
@Fred-sun Fred-sun changed the title Update azure_rm_publicipaddress Support IPv6 public ip address Sep 9, 2020
@haiyuazhang haiyuazhang changed the title Support IPv6 public ip address Support static IPv6 address Sep 9, 2020
@haiyuazhang haiyuazhang merged commit 5894e96 into ansible-collections:dev Sep 9, 2020
@Fred-sun Fred-sun deleted the update_publicipaddress branch December 31, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure_rm_publicipaddress cannot use Standard SKU with IPv6
3 participants