Add features to azure_rm_galleryimage #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
added
medium_priority
Add the parameter `features` to the `azure_rm_galleryimage` module, making it possible to create VMs with Trusted Launch from these images.
ephracis
force-pushed
the
1282-add-security-type-to-gallery-image
branch
from
6118666
to
73aa5bb
Compare
Switch gallery image definition to Hyper-V generation V2 and enable TrustedLaunch.
|
I've added some integration tests but that suite isn't working because it doesn't use |
Fred-sun
added
ready_for_review
xuzhang3
approved these changes
Nov 9, 2023
|
@ephracis LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add the parameter
featuresto theazure_rm_galleryimagemoduleFixes #1282
ISSUE TYPE
COMPONENT NAME
azure_rm_galleryimage
ADDITIONAL INFORMATION
This is required to create VMs with Trusted Launch from these images.
The API version had to be bumped in order to support the properties.features setting.