Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatible with two methods to obtaining azlogin credentials #1364

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Compatible with two methods to obtaining azlogin credentials #1364

merged 1 commit into from
Dec 11, 2023

Conversation

Fred-sun
Copy link
Collaborator

@Fred-sun Fred-sun commented Dec 8, 2023

SUMMARY

Compatible with two methods to obtaining azlogin credentials

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

azure_rm_common.py

ADDITIONAL INFORMATION

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority labels Dec 8, 2023
@xuzhang3 xuzhang3 merged commit bbdff6c into ansible-collections:dev Dec 11, 2023
@Fred-sun Fred-sun deleted the fix-azlogin-auth-bug branch December 25, 2023 02:07
@hkrutzer
Copy link

This breaks for me:

ansible_collections.azure.azcollection.plugins.inventory.azure_rm plugin: name 'AzureCliCredential' is not defined

File "ansible/collections/ansible_collections/azure/azcollection/plugins/module_utils/azure_rm_common.py", line 1589, in _get_azure_cli_credentials
    az_cli = AzureCliCredential()
             ^^^^^^^^^^^^^^^^^^

@Fred-sun
Copy link
Collaborator Author

@hkrutzer This class name is already imported in line 261. Can you check if you have installed 'azure-identity' and successfully imported 'AzureCliCredential'? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuzhang3 xuzhang3 xuzhang3 approved these changes

Assignees

@xuzhang3 xuzhang3

Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fred-sun @hkrutzer @xuzhang3