Add upper letter protocol to security group #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
added
the
ready_for_review
xuzhang3
approved these changes
Dec 19, 2023
|
Is this going to offer the different cases of option in autocomplete (via Ansible extension)? If yes, Respectfully, I don't think this is an elegant solution. The Module docs and developer experience is going to be ugly. I would instead propose a solution involving transforming the input case (all lower or all upper), so it takes care of the case matching in the background. |
|
@Mohammad-Atif-Khan Thank you very much for your reply! This choice is a choice that specifies the parameters, and some users prefer uppercase or uppercase. That's why the option is added. We have conversions in the module, which convert all the parameters passed in to uppercase. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add upper letter protocol to security group, try to fixes #1358
ISSUE TYPE
COMPONENT NAME
azure_rm_securitygroup.py
ADDITIONAL INFORMATION