Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microsoft.ContainerService/managedClusters to subnet delegations #1414

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

xrow
Copy link
Contributor

@xrow xrow commented Jan 22, 2024

SUMMARY

I am in the need of adding Microsoft.ContainerService/managedClusters delegation for AKS. Tough I think it might be also ok to remove all the array from the definition and let the Server API check the correct type. Please let me know if I can remove all type checking of the client lib.

  • Bugfix Pull Request
COMPONENT NAME

azure_rm_subnet.py

ADDITIONAL INFORMATION
- name: Create a subnet
  azure.azcollection.azure_rm_subnet:
    resource_group: global
    virtual_network_name: global
    name: "{{ cluster.name }}APISubnet"
    address_prefix_cidr: "{{ cluster.api_subnet }}"
    delegations:
    - serviceName: Microsoft.ContainerService/managedClusters
      name: ContainerService

@Fred-sun Fred-sun added medium_priority Medium priority work in In trying to solve, or in working with contributors enhancement New feature or request ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Jan 23, 2024
@xuzhang3 xuzhang3 merged commit 5451881 into ansible-collections:dev Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants