Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure_rm_adapplication to return all AD Applications. Enhancement to search for application by app_display_name #1420

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

kmj251
Copy link
Contributor

@kmj251 kmj251 commented Jan 23, 2024

SUMMARY
  • Add functionality to search for Application by app_display_name. Fix ad application search by tenant to return all applications.
  • Update test for azure_rm_adapplication to search by display name.
  • Some small documentation fixes.

Fixes #1419

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

azure_rm_adapplication_info

ADDITIONAL INFORMATION

Run a playbook with the following task in it:

- name: "Get all AD Applications from Tenant"
  azure.azcollection.azure_rm_adapplication_info:
    tenant: "{{ prod_tenant }}"
  register: ad_app_tenant_info

- name: "Print ad_app_tenant_info"
  ansible.builtin.debug:
    msg: "{{ ad_app_tenant_info.applications | length }}"
  when: 1 == 1
BEFORE:
TASK [Get all AD Applications from Tenant] **********************************************************************************************************************
ok: [localhost]

TASK [Print ad_app_tenant_info] *********************************************************************************************************************************
ok: [localhost] => {
    "msg": "100"
}

AFTER:
TASK [Get all AD Applications from Tenant] **********************************************************************************************************************
ok: [localhost]

TASK [Print ad_app_tenant_info] *********************************************************************************************************************************
ok: [localhost] => {
    "msg": "2458"
}

@Fred-sun Fred-sun added medium_priority Medium priority work in In trying to solve, or in working with contributors labels Jan 24, 2024
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Jan 25, 2024
@xuzhang3 xuzhang3 merged commit d3e90ba into ansible-collections:dev Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure_rm_adapplication_info only returns 100 applications when querying for all applications in the tenant
3 participants