Add support for disable_instance_discovery #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
added
medium_priority
|
Hello, Thanks for the review. It looks to me like azure-identity is already updated to 1.14.0. This was done in Commit 21f6e15 Thanks! |
|
@p3ck Please add a description of the parameter 'disable_instance_discovery' to the file ~/plugins/doc_fragments/ aze. py, which has the default value. Thank you! |
p3ck
force-pushed
the
issue-1236
branch
2 times, most recently
from
30efd1b
to
729b239
Compare
Fred-sun
reviewed
Feb 21, 2024
plugins/doc_fragments/azure.py
Outdated
| that the configured authority host is valid and trustworthy. | ||
| - Set via credential file profile or the C(AZURE_DISABLE_INSTANCE_DISCOVERY) environment variable. | ||
| type: bool | ||
| version_added: '2.2.1' |
There was a problem hiding this comment.
version-added-must-be-major-or-minor, such as '2.3.0'
Added support in ansible common to support setting disable_instance_discovery when using azure clouds and you don't have access to login.microsoftonline.com. This can be specified as a module argument, environment variable or in credential profile. To enable set to True, default if False which doesn't change the current behaviour. Updated doc fragment to explain how to use it. fix ansible-collections#1236
Fred-sun
added
ready_for_review
xuzhang3
approved these changes
Feb 29, 2024
xuzhang3
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added support in ansible common to support setting disable_instance_discovery when using azure clouds and you don't have access to login.microsoftonline.com.
This can be specified as a module argument, environment variable or in credential profile. To enable set to True, default if False which doesn't change the current behaviour.
Fixes #1236
ISSUE TYPE
COMPONENT NAME
azure_rm_common
ADDITIONAL INFORMATION
This issue affects users who are using the Azure US Government cloud
As of today the Azure Collection fails to connect in this environment:
Network access is allowed to Azure US Government cloud. (login.microsoftonline.us)
Network access is not allowed to Azure Public cloud. (login.microsoftonline.com)
Trying to use the Azure collection in this environment fails with attempts to connect to login.microsoftonline.com.