Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix listing all service principals #1482

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

kent007
Copy link
Contributor

@kent007 kent007 commented Mar 5, 2024

SUMMARY

Fixes #1481

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_adserviceprincipal_info

ADDITIONAL INFORMATION

I added reply pagination and also corrected the documentation to specify the results come back in a container

@Fred-sun Fred-sun added enhancement New feature or request medium_priority Medium priority work in In trying to solve, or in working with contributors labels Mar 6, 2024
Copy link
Collaborator

@Fred-sun Fred-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change qurest!

@kent007
Copy link
Contributor Author

kent007 commented Mar 6, 2024

I think comments should be addressed. I also included a new example

Copy link
Collaborator

@Fred-sun Fred-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change request!

plugins/modules/azure_rm_adserviceprincipal_info.py Outdated Show resolved Hide resolved
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Copy link
Collaborator

@Fred-sun Fred-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change request!

plugins/modules/azure_rm_adserviceprincipal_info.py Outdated Show resolved Hide resolved
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
@Fred-sun Fred-sun assigned xuzhang3 and unassigned xuzhang3 Mar 18, 2024
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Mar 18, 2024
@xuzhang3 xuzhang3 merged commit 56fd8ab into ansible-collections:dev Mar 22, 2024
@kent007 kent007 deleted the dev-serviceprincipals branch March 22, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ad_serviceprincipal_info does not properly list all service principals
3 participants