Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 'description' to azure_rm_adgroup #1492

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Support 'description' to azure_rm_adgroup #1492

merged 1 commit into from
Mar 18, 2024

Conversation

Fred-sun
Copy link
Collaborator

SUMMARY

Support 'description' to azure_rm_adgroup， try to fixes #1485

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

azure_rm_adgroup.py
azure_rm_adgroup_info.py

ADDITIONAL INFORMATION

@Fred-sun Fred-sun mentioned this pull request Mar 14, 2024
Closed
@Fred-sun Fred-sun assigned xuzhang3 and unassigned xuzhang3 Mar 14, 2024
@Fred-sun Fred-sun added enhancement New feature or request ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority labels Mar 14, 2024
hematic
hematic reviewed Mar 14, 2024
View reviewed changes
Copy link

@hematic hematic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to my eyes here. This is really needed functionality so thank you.

@xuzhang3 xuzhang3 merged commit af05233 into ansible-collections:dev Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hematic hematic hematic left review comments

@xuzhang3 xuzhang3 xuzhang3 approved these changes

Assignees

@xuzhang3 xuzhang3

Labels
enhancement New feature or request medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure.azcollection.azure_rm_adgroup module Should allow for setting the description of the group
3 participants
@Fred-sun @hematic @xuzhang3