Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery Services Vault #210 #254

Merged
merged 37 commits into from
Sep 17, 2020
Merged

Conversation

suyeb786
Copy link
Contributor

@suyeb786 suyeb786 commented Sep 9, 2020

SUMMARY

This module introduced Azure Recovery Service Vault features listed below

  1. Create Azure Recovery Services vault
  2. Update Azure Recovery Services vault
  3. Get Azure Recovery Services vault Details
  4. Delete Recovery Services vault.

#210

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_recoveryservicesvault
azure_rm_recoveryservicesvault_info

ADDITIONAL INFORMATION

@haiyuazhang
Copy link
Contributor

@suyeb786 thanks for contributing Yet another module!

plugins/modules/azure_rm_recoveryservicesvault.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_recoveryservicesvault.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_recoveryservicesvault.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_recoveryservicesvault.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_recoveryservicesvault_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_recoveryservicesvault_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_recoveryservicesvault_info.py Outdated Show resolved Hide resolved
@Fred-sun
Copy link
Collaborator

Okay, I will focus on reviewing this pull request tomorrow!

@Fred-sun
Copy link
Collaborator

Fred-sun commented Sep 14, 2020

@suyeb786 Can this module not be updated?
If a VM has been backed up, can I forcefully delete Recovery Services Vault?
This module is not designed to be idempotent? Is it not idempotent?

@suyeb786
Copy link
Contributor Author

@Fred-sun

FYI,
You can't delete a Recovery Services vault with any of the following dependencies:

You can't delete a vault that contains protected data sources (for example, IaaS VMs, SQL databases, Azure file shares).
You can't delete a vault that contains backup data. Once backup data is deleted, it will go into the soft-deleted state.
You can't delete a vault that contains backup data in the soft-deleted state.
You can't delete a vault that has registered storage accounts.

Also, Updated is already supported in module with idempotency.

@Fred-sun
Copy link
Collaborator

@suyeb786 Can you give an example of the final update and idempotence? Thank you!

@suyeb786
Copy link
Contributor Author

Hello @Fred-sun ,

Below is the API for creating and updating the Recovery Service Vault.
PUT https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}?api-version=2016-06-01

At the time of request if RSV is already present then it will simply update it else it will create a new with new name.

@suyeb786
Copy link
Contributor Author

@Fred-sun,
Any feedback on this?

@Fred-sun Fred-sun added new_module_pr Add new modules work in In trying to solve, or in working with contributors labels Sep 14, 2020
@Fred-sun
Copy link
Collaborator

@suyeb786 Please delete plugins/modules/azure_rm_recoveryservicesvault.py 175 lines whitespace! It should be perfect!

@haiyuazhang haiyuazhang merged commit a282541 into ansible-collections:dev Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new_module_pr Add new modules work in In trying to solve, or in working with contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants