Added new module for supporting DNS recordset operations in Private DNS zone and Resolved issue #265 #286

aparna-patil · 2020-10-11T17:06:34Z

SUMMARY
This module introduces following DNS record sets operations for a Private DNS zone.

Create DNS record set in a Private DNS zone
Update DNS record set in a Private DNS zone
Delete DNS record set in a Private DNS zone
Get DNS record set details from Private DNS zone

Fixes #265

ISSUE TYPE

New Module Pull Request

COMPONENT NAME
azure_rm_privatednsrecordset

ADDITIONAL INFORMATION
This module allows to perform the create/update, delete and list operations on DNS record sets in an existing Private DNS zone. Azure API doc - https://docs.microsoft.com/en-us/rest/api/dns/privatedns/recordsets/createorupdate

aparna-patil · 2020-10-12T06:23:41Z

Hi @Fred-sun, Could you please review this PR and provide your feedback? Thank you!

Fred-sun · 2020-10-12T06:29:18Z

Hi @Fred-sun, Could you please review this PR and provide your feedback? Thank you!

I will start reviewing this soon! Thank you!

Fred-sun

None of the parameters in the document have defined types!
"return" in the return value should be changed to "returned"！
The 72, 92, 125 lines of azure_rm_privatednsrecordset_info are repeated!

tests/integration/targets/azure_rm_privatednsrecordset/tasks/main.yml

Fred-sun

Please add the following two lines in ‘tests/sanity/ignore-2.10.txt’ and ’tests/sanity/ignore-2.11.txt‘!

plugins/modules/azure_rm_privatednsrecordset.py validate-modules:doc-elements-mismatch
plugins/modules/azure_rm_privatednsrecordset.py validate-modules:invalid-ansiblemodule-schema

plugins/modules/azure_rm_privatednsrecordset_info.py

aparna-patil · 2020-10-13T07:43:01Z

Please add the following two lines in ‘tests/sanity/ignore-2.10.txt’ and ’tests/sanity/ignore-2.11.txt‘!
plugins/modules/azure_rm_privatednsrecordset.py validate-modules:doc-elements-mismatch
plugins/modules/azure_rm_privatednsrecordset.py validate-modules:invalid-ansiblemodule-schema

Done, Added these 2 lines in ‘tests/sanity/ignore-2.10.txt’ and ’tests/sanity/ignore-2.11.txt‘. Thank you

aparna-patil · 2020-10-13T07:44:15Z

None of the parameters in the document have defined types!
"return" in the return value should be changed to "returned"！
The 72, 92, 125 lines of azure_rm_privatednsrecordset_info are repeated!

@Fred-sun , Done, Added the changes as suggested, Please review again and let me know if any other changes are required, Thank you!

aparna-patil · 2020-10-19T11:32:45Z

Hi @Fred-sun, Kindly let me know if any other changes required in this PR? I have incorporated all the previous suggested changes. could you please take a look at it once and share your feedback? Thank you!

plugins/modules/azure_rm_privatednsrecordset_info.py

Fred-sun · 2020-10-22T05:42:33Z

@aparna-patil There are still many formatting errors in the document! Please refer to the link ---"https://docs.ansible.com/ansible/latest/dev_guide/testing_integration.html", the command is --"ansible-test sanity --color -v --junit”

ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:23:118: W291: trailing whitespace
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: deprecation-mismatch: "meta/runtime.yml" and DOCUMENTATION.deprecation do not agree.
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: doc-choices-do-not-match-spec: Argument 'auth_source' in argument_spec defines choices as (['auto', 'cli', 'env', 'credential_file', 'msi']) but documentation defines choices as ([])
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: doc-choices-do-not-match-spec: Argument 'cert_validation_mode' in argument_spec defines choices as (['validate', 'ignore']) but documentation defines choices as ([])
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: doc-default-does-not-match-spec: Argument 'api_profile' in argument_spec defines default as ('latest') but documentation defines default as (None)
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: doc-default-does-not-match-spec: Argument 'append_tags' in argument_spec defines default as (True) but documentation defines default as (False)
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: doc-default-does-not-match-spec: Argument 'auth_source' in argument_spec defines default as ('auto') but documentation defines default as (None)
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: doc-default-does-not-match-spec: Argument 'cloud_environment' in argument_spec defines default as ('AzureCloud') but documentation defines default as (None)
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'ad_user' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'adfs_authority_url' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'api_profile' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'append_tags' in argument_spec defines type as 'bool' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'auth_source' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'cert_validation_mode' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'client_id' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'cloud_environment' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'password' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'profile' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'record_type' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'relative_name' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'resource_group' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'secret' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'subscription_id' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'tags' in argument_spec defines type as 'dict' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'tenant' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'top' in argument_spec defines type as 'int' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'zone_name' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:43:5: documentation-syntax-error: DOCUMENTATION is not valid YAML
ERROR: tests/sanity/ignore-2.10.txt:725:1: A100: Ignoring 'doc-elements-mismatch' on 'plugins/modules/azure_rm_privatednsrecordset.py' is unnecessar

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

aparna-patil · 2020-10-26T12:05:04Z

@aparna-patil There are still many formatting errors in the document! Please refer to the link ---"https://docs.ansible.com/ansible/latest/dev_guide/testing_integration.html", the command is --"ansible-test sanity --color -v --junit”

ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:23:118: W291: trailing whitespace
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: deprecation-mismatch: "meta/runtime.yml" and DOCUMENTATION.deprecation do not agree.
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: doc-choices-do-not-match-spec: Argument 'auth_source' in argument_spec defines choices as (['auto', 'cli', 'env', 'credential_file', 'msi']) but documentation defines choices as ([])
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: doc-choices-do-not-match-spec: Argument 'cert_validation_mode' in argument_spec defines choices as (['validate', 'ignore']) but documentation defines choices as ([])
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: doc-default-does-not-match-spec: Argument 'api_profile' in argument_spec defines default as ('latest') but documentation defines default as (None)
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: doc-default-does-not-match-spec: Argument 'append_tags' in argument_spec defines default as (True) but documentation defines default as (False)
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: doc-default-does-not-match-spec: Argument 'auth_source' in argument_spec defines default as ('auto') but documentation defines default as (None)
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: doc-default-does-not-match-spec: Argument 'cloud_environment' in argument_spec defines default as ('AzureCloud') but documentation defines default as (None)
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'ad_user' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'adfs_authority_url' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'api_profile' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'append_tags' in argument_spec defines type as 'bool' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'auth_source' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'cert_validation_mode' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'client_id' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'cloud_environment' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'password' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'profile' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'record_type' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'relative_name' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'resource_group' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'secret' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'subscription_id' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'tags' in argument_spec defines type as 'dict' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'tenant' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'top' in argument_spec defines type as 'int' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:0:0: parameter-type-not-in-doc: Argument 'zone_name' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_privatednsrecordset_info.py:43:5: documentation-syntax-error: DOCUMENTATION is not valid YAML
ERROR: tests/sanity/ignore-2.10.txt:725:1: A100: Ignoring 'doc-elements-mismatch' on 'plugins/modules/azure_rm_privatednsrecordset.py' is unnecessar

Hi @Fred-sun , I have corrected the documentation errors. Could you please check once and provide your feedback? Thanks.

Fred-sun

fixes sanity errors!

tests/sanity/ignore-2.10.txt

tests/sanity/ignore-2.11.txt

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

aparna-patil · 2020-10-26T12:57:27Z

@Fred-sun Committed the suggested changes in sanity tests files

Fred-sun · 2020-10-27T00:37:26Z

@Fred-sun Committed the suggested changes in sanity tests files

All test pass! I will push for merge! Thank you very much!

Fred-sun reviewed Oct 12, 2020

View reviewed changes

tests/integration/targets/azure_rm_privatednsrecordset/tasks/main.yml Show resolved Hide resolved

Fred-sun reviewed Oct 12, 2020

View reviewed changes

plugins/modules/azure_rm_privatednsrecordset_info.py Outdated Show resolved Hide resolved

Fred-sun added medium_priority Medium priority new_module_pr Add new modules work in In trying to solve, or in working with contributors labels Oct 12, 2020

Fred-sun reviewed Oct 22, 2020

View reviewed changes

plugins/modules/azure_rm_privatednsrecordset_info.py Outdated Show resolved Hide resolved

aparna-patil and others added 4 commits October 26, 2020 14:51

Resolved issue #265

91d0cbb

Incorporated all the review comments

8be78c2

Update plugins/modules/azure_rm_privatednsrecordset_info.py

9c1a0db

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

Corrected documentation

77921ac

Fred-sun reviewed Oct 26, 2020

View reviewed changes

tests/sanity/ignore-2.10.txt Outdated Show resolved Hide resolved

tests/sanity/ignore-2.11.txt Outdated Show resolved Hide resolved

aparna-patil and others added 2 commits October 26, 2020 18:07

Update tests/sanity/ignore-2.10.txt

4db7270

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

Update tests/sanity/ignore-2.11.txt

2d32d36

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

Fred-sun added the ready_for_review The PR has been modified and can be reviewed and merged label Oct 26, 2020

haiyuazhang merged commit 6004362 into ansible-collections:dev Oct 28, 2020

aparna-patil deleted the 265-privateDNSRecordset branch October 29, 2020 13:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added new module for supporting DNS recordset operations in Private DNS zone and Resolved issue #265 #286

Added new module for supporting DNS recordset operations in Private DNS zone and Resolved issue #265 #286

aparna-patil commented Oct 11, 2020

aparna-patil commented Oct 12, 2020

Fred-sun commented Oct 12, 2020

Fred-sun left a comment •

edited

Loading

Fred-sun left a comment

aparna-patil commented Oct 13, 2020

aparna-patil commented Oct 13, 2020

aparna-patil commented Oct 19, 2020

Fred-sun commented Oct 22, 2020

aparna-patil commented Oct 26, 2020

Fred-sun left a comment

aparna-patil commented Oct 26, 2020

Fred-sun commented Oct 27, 2020

Added new module for supporting DNS recordset operations in Private DNS zone and Resolved issue #265 #286

Added new module for supporting DNS recordset operations in Private DNS zone and Resolved issue #265 #286

Conversation

aparna-patil commented Oct 11, 2020

aparna-patil commented Oct 12, 2020

Fred-sun commented Oct 12, 2020

Fred-sun left a comment • edited Loading

Choose a reason for hiding this comment

Fred-sun left a comment

Choose a reason for hiding this comment

aparna-patil commented Oct 13, 2020

aparna-patil commented Oct 13, 2020

aparna-patil commented Oct 19, 2020

Fred-sun commented Oct 22, 2020

aparna-patil commented Oct 26, 2020

Fred-sun left a comment

Choose a reason for hiding this comment

aparna-patil commented Oct 26, 2020

Fred-sun commented Oct 27, 2020

Fred-sun left a comment •

edited

Loading