fix azure_rm_keyvault idempotency #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
added
medium_priority
Eugen1987
force-pushed
the
bug/fix-keyvault-idempotency
branch
from
494b1af
to
9b3f3d3
Compare
Fred-sun
reviewed
Oct 22, 2020
Eugen1987
force-pushed
the
bug/fix-keyvault-idempotency
branch
from
9b3f3d3
to
15332bb
Compare
Fred-sun
added
ready_for_review
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The part where the idempotence is checked is not working properly, there are several cases:
The 'enabled_soft_delete' attribute has never existed. The correct one is: 'enable_soft_delete
The attributes: tenant_id, enabled_for_deployment, enabled_for_disk_encryption, enabled_for_template_deployment, enable_soft_delete are inside the 'properties' dictionary and not at the same level.
The attribute 'create_mode' is not part of the idempotence since the only thing it does is to recover the keyvault with the data it had before in case the option 'recover_mode' is 'true'. It also does not come in the structure: old_response['create_mode']
Fixes #292
ISSUE TYPE
COMPONENT NAME
azure_rm_keyvault
ADDITIONAL INFORMATION
None