Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manageddisk info managed by #302

Merged

Conversation

paultaiton
Copy link
Contributor

SUMMARY

Fixed some bugs with azure_rm_manageddisk_info, and added a new managed_by parameter that will filter for only disks managed by a given VM fqid. Made code more concise and more explicit, changed ambiguous function names to more descriptive.

Fixed tag string type problem (should be list,) as well as failures when tags was not a defined parameter.

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

azure_rm_manageddisk_info

ADDITIONAL INFORMATION

@Fred-sun
Copy link
Collaborator

@paultaiton Please delete the line of the following file --”plugins/modules/azure_rm_manageddisk_info.py validate-modules:doc-type-does-not-match-spec“

tests/sanity/ignore-2.9.txt
tests/sanity/ignore-2.10.txt
tests/sanity/ignore-2.11.txt

@Fred-sun
Copy link
Collaborator

@paultaiton Please add the line to the following file --"plugins/modules/azure_rm_manageddisk_info.py validate-modules:parameter-list-no-elements"

tests/sanity/ignore-2.10.txt
tests/sanity/ignore-2.11.txt

@Fred-sun Fred-sun mentioned this pull request Oct 22, 2020
@paultaiton
Copy link
Contributor Author

@Fred-sun
I have committed your suggestions.
Can you explain or point me towards docs that explain what these files and changes have done? I'd like to understand them better.

@Fred-sun
Copy link
Collaborator

@paultaiton Please reference this link ---https://docs.ansible.com/ansible/latest/dev_guide/testing_integration.html , Thank you very much!

command: ansible-test sanity --color -v --junit

@Fred-sun Fred-sun added medium_priority Medium priority work in In trying to solve, or in working with contributors ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Oct 23, 2020
@haiyuazhang haiyuazhang merged commit b697acc into ansible-collections:dev Oct 26, 2020
@paultaiton paultaiton deleted the manageddisk_info-managed_by branch October 26, 2020 06:16
@paultaiton
Copy link
Contributor Author

Thanks for your help @Fred-sun and @haiyuazhang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants