Add new module to manage backup policies

[coleneubauer]

SUMMARY

Addition of a module to manage azure recovery services vault policies. The goal of the module is to manage the creation and deletion of backup policies of existing recovery services vaults.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

azure_rm_backuppolicy

ADDITIONAL INFORMATION

This is the addition of a new module. It currently only supports daily and weekly policies for Azure VMs but design consideration was taken to ensure this is easily expandable and new additions would be backwards compatible by having the policy type and run frequency as parameters.

After running with the state: present flag the policy specified will either be created or updated if a matching one exists. Matching would be defined by the policy name, vault name, and resource group matching.

After running with the state: absent flag the policy specified would be deleted if present or no change would occur if the policy is not.

[Fred-sun]

@coleneubauer Thank you for submitting PR. You can check the module through the link below. Thank you very much!

link: https://docs.ansible.com/ansible/devel/dev_guide/testing_sanity.html#testing-sanity

[coleneubauer]

@Fred-sun Thank you for providing the sanity test resource. I fixed the issues in the latest commit.

[Fred-sun]

@coleneubauer Please add dependence info to requirements-azure.txt (azure-mgmt-recoveryservicesbackup and azure-mgmt-recoveryservices)! Thank you very much!

[coleneubauer]

@Fred-sun Thank you for pointing out the missing dependencies. I updated the pr to include the dependencies in the requirements-azure.txt

[Fred-sun]

@coleneubasuer Please help to format the document, and update the name of the class parameter, to maintain the consistency with other module naming! Thank you very much!

[Fred-sun]

@coleneubauer Also,would you help add azure_rm_backuppolicy_info module and add the example related to azure_rm_backupolicy_info.py to main.yml. Thank you very much!

[coleneubauer]

@Fred-sun I have made the suggested updates

@coleneubasuer Please help to format the document, and update the name of the class parameter, to maintain the consistency with other module naming! Thank you very much!

[coleneubauer]

I can do this. Should this be in its own PR or tacked onto this one?

@coleneubauer Also,would you help add azure_rm_backuppolicy_info module and add the example related to azure_rm_backupolicy_info.py to main.yml. Thank you very much!

[Fred-sun]

can do this. Should this be in its own PR or tacked onto this one?

@coleneubauer Yes, so that we main.yml can manage this module and get information! Thank you very much!

[coleneubauer]

@Fred-sun I've added the info module and tested it. Everything is working. With the sanity test for the info module, I'm getting an error message talking about missing parameters in the documentation that the parent object is using. These params are only defined in the AzureRMModuleBase class. It is not referenced in the info class. Do you know why this error is happening? It should be ready to merge otherwise. See below

ERROR: Found 2 validate-modules issue(s) which need to be resolved:
ERROR: plugins/modules/azure_rm_backuppolicy_info.py:0:0: required_if-requirements-unknown: required_if contains terms in requirements which are not part of argument_spec: log_path
ERROR: plugins/modules/azure_rm_backuppolicy_info.py:0:0: required_if-unknown-key: required_if must have its key log_mode in argument_spec

[coleneubauer]

@Fred-sun Info module is added. Both modules pass sanity tests. Added the info module to the tests and ran some test playbooks of both modules. Let me know if there's anything else you need before this can be merged. Thanks!

[Fred-sun]

@coleneubauser Please distinguish the two names. When you have finished the change, I will push forward the PR merge. Thank you very much!

[coleneubauer]

@coleneubauser Please distinguish the two names. When you have finished the change, I will push forward the PR merge. Thank you very much!

This has now been updated and should now be ready to merge. Thank you.