Optimizing ado.sh #510
Merged
Optimizing ado.sh #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
added
medium_priority
Fred-sun
added
work in
Fred-sun
added
ready_for_review
tfmark
reviewed
Apr 28, 2021
| pip3 --version | ||
| pip3 list --disable-pip-version-check | ||
| alias pip='pip3' | ||
| sudo apt update |
There was a problem hiding this comment.
could you check if "$UID" -eq "0" here instead of always performing sudo? It would be nice to be able to run this easily from inside a Docker container
* class are worngly named. fixed. * fixing sanity errors.
haiyuazhang
force-pushed
the
dev
branch
2 times, most recently
from
2281f46
to
8dfc8ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Don't merge! For test!
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION