Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name to return data_disks #565

Merged
merged 4 commits into from
Jun 17, 2021

Conversation

Fred-sun
Copy link
Collaborator

@Fred-sun Fred-sun commented Jun 11, 2021

SUMMARY

add name to return data_disks, try to fix #444,#443.
Disable azure_rm_apimanagement task.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_virtualmachine_info.py

ADDITIONAL INFORMATION

@Fred-sun Fred-sun added the ready_for_review The PR has been modified and can be reviewed and merged label Jun 15, 2021
@Fred-sun Fred-sun added work in In trying to solve, or in working with contributors and removed ready_for_review The PR has been modified and can be reviewed and merged labels Jun 15, 2021
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Jun 15, 2021
@xuzhang3 xuzhang3 self-requested a review June 17, 2021 07:34
Copy link
Collaborator

@xuzhang3 xuzhang3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuzhang3 xuzhang3 merged commit 15640ea into ansible-collections:dev Jun 17, 2021
Fred-sun added a commit to Fred-sun/ansible_collections_azure that referenced this pull request Aug 11, 2021
* add name to return data_disks, try to fix ansible-collections#444

* add loop for azure_rm_apimanagement test

* Use get method for dict value

* disable azure_rm_apimanagement test, the api management service is activating after create(more than 1 hour)
@Fred-sun Fred-sun deleted the Update_virtualmachine branch December 31, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include data_disk name in return values for "azure_rm_virtualmachine_info"
2 participants