Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application gateway start/stop ability and info module #673

Merged
merged 11 commits into from
Dec 9, 2021
Merged

Application gateway start/stop ability and info module #673

merged 11 commits into from
Dec 9, 2021

Conversation

l3ender
Copy link
Contributor

@l3ender l3ender commented Nov 5, 2021 •
edited
Loading

SUMMARY

This PR:

  • adds the ability to start and stop already-created application gateways.
  • adds a few additional return values for module.
  • adds an info/facts module for application gateway.
ISSUE TYPE
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

azure_rm_appgateway
azure_rm_appgateway_info

@l3ender
Copy link
Contributor Author

l3ender commented Nov 6, 2021

@Fred-sun Please review--thank you!

@Fred-sun
Copy link
Collaborator

Fred-sun commented Nov 8, 2021

@l3ender Thank you for your contribution. We will complete the review and push forward the merger as soon as possible.

@Fred-sun Fred-sun added medium_priority Medium priority new_feature New feature requirments work in In trying to solve, or in working with contributors labels Nov 8, 2021
@l3ender l3ender changed the title Application gateway info module and start/stop ability Application gateway start/stop ability and info module Nov 13, 2021
@Fred-sun
Copy link
Collaborator

@l3ender To be consistent with other modules, it is recommended that you merge the azure_rm_appgateway and azure_rm_appgateway_info test cases. Thank you!

@l3ender
Copy link
Contributor Author

l3ender commented Nov 29, 2021

@Fred-sun azure_rm_appgateway and azure_rm_appgateway_info test cases have been merged. Thank you!

@Fred-sun Fred-sun added the ready_for_review The PR has been modified and can be reviewed and merged label Dec 1, 2021
@Fred-sun Fred-sun removed the work in In trying to solve, or in working with contributors label Dec 1, 2021
@xuzhang3
Copy link
Collaborator

xuzhang3 commented Dec 8, 2021

@l3ender can you help resolve the conflict?

@l3ender
Copy link
Contributor Author

l3ender commented Dec 9, 2021

@xuzhang3 Conflicts resolved...thank you!

@xuzhang3
Copy link
Collaborator

xuzhang3 commented Dec 9, 2021

LGTM

@xuzhang3 xuzhang3 merged commit 813c46a into ansible-collections:dev Dec 9, 2021
@xuzhang3 xuzhang3 deleted the appgw-enhancements branch December 9, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xuzhang3 xuzhang3

Labels
medium_priority Medium priority new_feature New feature requirments ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@l3ender @Fred-sun @xuzhang3