Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align azure_rm_securitygroup_info return to match azure_rm_securitygroup #726

Merged
merged 3 commits into from
Jan 12, 2022

Conversation

l3ender
Copy link
Contributor

@l3ender l3ender commented Jan 10, 2022

SUMMARY

This PR updates the return values of azure_rm_securitygroup_info to match the return values of azure_rm_securitygroup.

Because of the update, this should be considered a breaking change, as the previously used properties field is no longer returned.

Fixes #636. Note that there is no test coverage for the fix because there is no module to create NSG flow logs. Flow logs will need to be manually configured on an NSG in order to test.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_securitygroup_info

ADDITIONAL INFORMATION

A playbook which tests the info module:

---
- name: "Playbook for testing."
  hosts: "localhost"
  connection: "local"
  gather_facts: false
  vars:
    resource_group: "automated-testing"
    resource_group_secondary: "automated-testing-secondary"
  collections:
    - azure.azcollection

  tasks:
    - name: "Include tests"
      include_tasks: "tests/integration/targets/azure_rm_securitygroup/tasks/main.yml"

@l3ender
Copy link
Contributor Author

l3ender commented Jan 10, 2022

@Fred-sun FYI...thank you!

@xuzhang3
Copy link
Collaborator

LGTM

@xuzhang3 xuzhang3 merged commit 761c1f2 into ansible-collections:dev Jan 12, 2022
@xuzhang3 xuzhang3 deleted the nsg-info-flowlogs branch January 12, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
3 participants