Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zones feature to azure_rm_publicipaddres module #829

Merged
merged 3 commits into from
May 5, 2022
Merged

Add zones feature to azure_rm_publicipaddres module #829

merged 3 commits into from
May 5, 2022

Conversation

Fred-sun
Copy link
Collaborator

SUMMARY

Add zones feature to azure_rm_publicipaddres module. try to fixes #802

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_publicipaddress.py
azure_rm_publicipaddress_info.py

ADDITIONAL INFORMATION

@Fred-sun Fred-sun added medium_priority Medium priority new_feature New feature requirments work in In trying to solve, or in working with contributors labels Apr 20, 2022
@Fred-sun Fred-sun mentioned this pull request Apr 20, 2022
Closed
@verhyppo
Copy link
Contributor

verhyppo commented May 1, 2022

Hi @Fred-sun, who should review this PR?
The fix LGTM.
Do you need someone to test the fix with the playbooks that were not working?

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels May 2, 2022
@xuzhang3
Copy link
Collaborator

xuzhang3 commented May 5, 2022

LGTM, shipping it 🛥️

@xuzhang3 xuzhang3 merged commit 6b065a7 into ansible-collections:dev May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xuzhang3 xuzhang3

Labels
medium_priority Medium priority new_feature New feature requirments ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure_rm_publicipaddress does not support availability zones
3 participants
@Fred-sun @verhyppo @xuzhang3