Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Storage dependencies #833

Merged
merged 11 commits into from
Jun 8, 2022

Conversation

l3ender
Copy link
Contributor

@l3ender l3ender commented Apr 25, 2022

SUMMARY

This PR updates the Azure storage-related modules in order to support additional features. Since the azure-storage dependency has been deprecated, the collection was updated to use azure-storage-blob.

Fixes #130.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • azure_rm_storageaccount
  • azure_rm_storageblob
ADDITIONAL INFORMATION

Important!!! If updating an existing python environment, the old dependency should be uninstalled:

pip uninstall azure-storage

The following playbook can be used to run storage tests:

---
- name: "Playbook for testing."
  hosts: "localhost"
  connection: "local"
  gather_facts: false
  vars:
    resource_group: "automated-testing"
    resource_group_secondary: "automated-testing-secondary"
  collections:
    - azure.azcollection

  tasks:
    - name: "Include storage account tests"
      include_tasks: "tests/integration/targets/azure_rm_storageaccount/tasks/main.yml"

    - name: "Include storage blob tests"
      include_tasks: "tests/integration/targets/azure_rm_storageblob/tasks/main.yml"
      vars:
        test1_file: "tests/integration/targets/azure_rm_storageblob/files/Ratings.png"

@Fred-sun Fred-sun added work in In trying to solve, or in working with contributors enhancement New feature or request medium_priority Medium priority labels Apr 25, 2022
@l3ender l3ender changed the title Storage enhancements Update Storage dependencies Apr 26, 2022
@l3ender l3ender marked this pull request as ready for review April 26, 2022 15:07
@l3ender
Copy link
Contributor Author

l3ender commented Apr 26, 2022

Hi @Fred-sun, could you please take a look at this PR? I've run ansible-test (integration and sanity) for both storageaccount and storageblob; everything appears to be working so I believe the PR is ready.

I plan to work on #459 and #780 next, but thought it would be good to do those in a separate PR.

Thank you!

@l3ender
Copy link
Contributor Author

l3ender commented May 9, 2022

Hi @Fred-sun, can you please inspect this PR? Thank you!

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels May 25, 2022
@Fred-sun Fred-sun assigned xuzhang3 and unassigned xuzhang3 May 25, 2022
@Fred-sun Fred-sun removed the ready_for_review The PR has been modified and can be reviewed and merged label May 25, 2022
@Fred-sun Fred-sun added the ready_for_review The PR has been modified and can be reviewed and merged label May 27, 2022
@xuzhang3
Copy link
Collaborator

xuzhang3 commented Jun 8, 2022

@l3ender LGTM, thanks

@xuzhang3 xuzhang3 merged commit 58a7f87 into ansible-collections:dev Jun 8, 2022
@xuzhang3 xuzhang3 deleted the storage-account-updates branch June 8, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ansible Azure library version issues
3 participants