Add new module azure_rm_account_info to get facts for current logged in user
#922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abikouo
suggested changes
Jul 19, 2022
There was a problem hiding this comment.
@mandar242 Thanks for this pull request.
Could you please add some integration tests for this module?
| except CloudError as exc: | ||
| self.fail("Failed to list all subscriptions - {0}".format(str(exc))) | ||
|
|
||
| results['id'] = subscription_list_response[0].subscription_id |
There was a problem hiding this comment.
is this a choice to return only the first subscription [0] for the account?
There was a problem hiding this comment.
Looking at the documentation and based on my trial-errors for az account show here: https://docs.microsoft.com/en-us/cli/azure/account?view=azure-cli-latest#az-account-show
I felt that it returns a single subscription, so adding [0]th subscription.
I could be wrong here though. Thoughts?
abikouo
suggested changes
Jul 21, 2022
Fred-sun
added
new_module_pr
Fred-sun
reviewed
Jul 26, 2022
Fred-sun
reviewed
Jul 26, 2022
Fred-sun
added
ready_for_review
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add new module
azure_rm_account_info.Provides output equivalent to
az account show.ISSUE TYPE
COMPONENT NAME
azure_rm_account_info
ADDITIONAL INFORMATION
Makes use of below to create a output containing details similar to and of similar format to
az account show