Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes asa_acls to add the support for network object #178

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jozzus
Copy link
Contributor

@jozzus jozzus commented Sep 11, 2022

Fixes asa_acls to add the support for network object under source/destination option
Fix parsing for zero compressed IPv6 addresses

SUMMARY

Add support for network object as src/dst option
Fixing ipv6 ace parsing which contains uncompressed ipv6 address (does not contain :: in it)

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

cisco.asa.asa_acls

ADDITIONAL INFORMATION

ACL entries which contains objects can not be parsed correctly as wall as such aces can't be defined.

@softwarefactory-project-zuul
Copy link

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 56s
✔️ build-ansible-collection SUCCESS in 4m 21s
ansible-test-network-integration-asa-python39 FAILURE in 7m 08s (non-voting)
ansible-test-network-integration-asa-python38-stable212 FAILURE in 7m 27s (non-voting)
ansible-test-network-integration-asa-python38-stable211 FAILURE in 7m 12s (non-voting)
ansible-test-network-integration-asa-python38-stable29 FAILURE in 8m 05s (non-voting)
✔️ ansible-test-network-integration-asa-libssh-python39 SUCCESS in 14m 46s
✔️ ansible-test-network-integration-asa-libssh-python38-stable212 SUCCESS in 13m 57s
✔️ ansible-test-network-integration-asa-libssh-python38-stable211 SUCCESS in 15m 43s
ansible-test-network-integration-asa-libssh-python38-stable29 FAILURE in 15m 53s (non-voting)
✔️ ansible-changelog-fragment SUCCESS in 19s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 33s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 50s
ansible-test-sanity-docker-stable-2.9 FAILURE in 10m 45s
ansible-test-sanity-docker-stable-2.10 FAILURE in 9m 02s
ansible-test-sanity-docker-stable-2.11 FAILURE in 10m 34s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 18s
✔️ ansible-test-units-asa-python39 SUCCESS in 5m 44s
✔️ ansible-test-units-asa-python36 SUCCESS in 6m 00s
✔️ ansible-test-units-asa-python37 SUCCESS in 6m 09s
✔️ ansible-tox-linters SUCCESS in 4m 51s

@softwarefactory-project-zuul
Copy link

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 35s
✔️ build-ansible-collection SUCCESS in 3m 54s
ansible-test-network-integration-asa-python39 FAILURE in 7m 03s (non-voting)
ansible-test-network-integration-asa-python38-stable212 FAILURE in 6m 58s (non-voting)
ansible-test-network-integration-asa-python38-stable211 FAILURE in 6m 58s (non-voting)
ansible-test-network-integration-asa-python38-stable29 FAILURE in 7m 57s (non-voting)
✔️ ansible-test-network-integration-asa-libssh-python39 SUCCESS in 14m 39s
✔️ ansible-test-network-integration-asa-libssh-python38-stable212 SUCCESS in 14m 20s
✔️ ansible-test-network-integration-asa-libssh-python38-stable211 SUCCESS in 14m 04s
ansible-test-network-integration-asa-libssh-python38-stable29 FAILURE in 14m 02s (non-voting)
✔️ ansible-changelog-fragment SUCCESS in 20s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 08s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 06s
ansible-test-sanity-docker-stable-2.9 FAILURE in 9m 40s
ansible-test-sanity-docker-stable-2.10 FAILURE in 10m 07s
ansible-test-sanity-docker-stable-2.11 FAILURE in 11m 14s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 39s
✔️ ansible-test-units-asa-python39 SUCCESS in 6m 26s
✔️ ansible-test-units-asa-python36 SUCCESS in 7m 17s
✔️ ansible-test-units-asa-python37 SUCCESS in 6m 03s
✔️ ansible-tox-linters SUCCESS in 4m 49s

@justjais
Copy link
Member

@jozzus Thanks for raising the PR, can you plz fix the test failures for us to go ahead with the PR merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants