Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nxos_user: Do not fail when a custom role is used #130

Merged
merged 2 commits into from
Jul 31, 2020

Conversation

NilashishC
Copy link
Collaborator

Signed-off-by: NilashishC nilashishchakraborty8@gmail.com

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_user.py

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Copy link
Collaborator Author

recheck

@NilashishC NilashishC added the gate Gate PR in Zuul CI label Jul 31, 2020
@ansible-zuul ansible-zuul bot merged commit bf36b71 into ansible-collections:main Jul 31, 2020
NilashishC added a commit to NilashishC/ansible that referenced this pull request Aug 3, 2020
NilashishC added a commit to NilashishC/ansible that referenced this pull request Aug 3, 2020
relrod pushed a commit to ansible/ansible that referenced this pull request Aug 6, 2020
@NilashishC NilashishC deleted the fix_nxos_user_roles branch August 11, 2020 05:03
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Aug 24, 2020
v2.9.12
=======

Minor Changes
-------------
- ansible-test - the ACME test container was updated, it now supports external account creation and has a basic OCSP responder (ansible/ansible#71097, https://github.com/ansible/acme-test-container/releases/tag/2.0.0).
- debconf - add a note about no_log=True since module might expose sensitive information to logs (ansible/ansible#32386).

Security Fixes
--------------
- **security issue** - copy - Redact the value of the no_log 'content' parameter in the result's invocation.module_args in check mode. Previously when used with check mode and with '-vvv', the module would not censor the content if a change would be made to the destination path. (CVE-2020-14332)

- **security issue** atomic_move - change default permissions when creating temporary files so they are not world readable (ansible/ansible#67794) (CVE-2020-1736)

- Fix warning for default permission change when no mode is specified. Follow up to ansible/ansible#67794. (CVE-2020-1736)

- Sanitize no_log values from any response keys that might be returned from the uri module (CVE-2020-14330).
- reset logging level to INFO due to CVE-2019-14846.

Bugfixes
--------
- Address compat with rpmfluff-0.6 for integration tests
- Ensure password passed in by -k is used on delegated hosts that do not have ansible_password set
- Template connection variables before using them (ansible/ansible#70598).
- Terminal plugins - add "\e[m" to the list of ANSI sequences stripped from device output
- add magic/connection vars updates from delegated host info.
- ansible-galaxy collection install - fix fallback mechanism if the AH server did not have the collection requested - ansible/ansible#70940
- ansible-test - Add ``pytest < 6.0.0`` constraint for managed installations on Python 3.x to avoid issues with relative imports.
- ansible-test - Change detection now properly resolves relative imports instead of treating them as absolute imports.
- api - time.clock is removed in Python 3.8, add backward compatible code (ansible/ansible#70649).
- avoid clobbering existing facts inside loop when task also returns ansible_facts.
- basic - use PollSelector implementation when DefaultSelector fails (ansible/ansible#70238).
- cron - encode and decode crontab files in UTF-8 explicitly to allow non-ascii chars in cron filepath and job (ansible/ansible#69492)
- ensure delegated vars can resolve hostvars object and access vars from hostvars[inventory_hostname].
- facts - account for Slackware OS with ``+`` in the name (ansible/ansible#38760)
- facts - fix incorrect UTC timestamp in ``iso8601_micro`` and ``iso8601``
- fix issue with inventory_hostname and delegated host vars mixing on connection settings.
- hashi_vault - Handle equal sign in key=value (ansible/ansible#55658).
- ipa_hostgroup - fix an issue with load-balanced ipa and cookie handling with Python 3 - (ansible/ansible#71110).
- lineinfile - fix not subscriptable error in exception handling around file creation
- linux network facts - get the correct value for broadcast address (ansible/ansible#64384)
- mysql_user - fix overriding password to the same (ansible-collections/community.general#543).
- net_put - Fixed UnboundLocalError when there is no change This is a backport from U(ansible-collections/ansible.netcommon#6)
- nxos_user - do not fail when a custom role is used (ansible-collections/cisco.nxos#130)
- ovirt_vm - fix cd_iso search
- playbooks - detect and propagate failures in ``always`` blocks after ``rescue`` (ansible/ansible#70000)
- profile_tasks - typecast result before slicing it (ansible/ansible#59059).
- reboot - Add support for the runit init system, used on Void Linux, that does not support the normal Linux syntax.
- redfish_info, redfish_config, redfish_command - Fix Redfish response payload decode on Python 3.5 (ansible/ansible#65889)
- shell - fix quoting of mkdir command in creation of remote_tmp in order to allow spaces and other special characters (ansible/ansible#69577).
- templating - fix error message for ``x in y`` when y is undefined (ansible/ansible#70984)
- unarchive - check ``fut_gid`` against ``run_gid`` in addition to supplemental groups (ansible/ansible#49284)
- user - don't create home directory and missing parents when create_home == false (ansible/ansible#70600).
- yum - fix yum list crashing if repoquery (used internally) prints errors in stdout (ansible/ansible#56800)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate Gate PR in Zuul CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nxos_user "VALID_ROLES" doesn't account for locally configured roles
2 participants