Republish nxos_file_copy changes #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
recheck |
|
recheck |
1 similar comment
|
recheck |
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #52
SUMMARY
The following is the list of changes included in this PR. The fix involves two parts:
bad_transport.yaml - the assert statement was checking for a wrong message. The actual message retuendd from the module is different. So the YAML file is fixed ot check for correct message
nxos_file_copy.py - There are a couple of places in this module where a replace is used with byte string. This is not working in python 3.8. The fix is to change the byte string to a string and then use replace the required string.
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
nxos_file_copy
ADDITIONAL INFORMATION
The issue is seen when the test case is executed without any additional steps.